Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

71X - update RelVal input for AK4 migration #3793

Merged
merged 1 commit into from
May 10, 2014
Merged

71X - update RelVal input for AK4 migration #3793

merged 1 commit into from
May 10, 2014

Conversation

vadler
Copy link

@vadler vadler commented May 9, 2014

Use RelVals from CMSSW_7_1_0_pre4_AK4 as test input after AK4 migration merge.

@vadler vadler mentioned this pull request May 9, 2014
Merged
@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2014

A new Pull Request was created by @vadler (Volker Adler) for CMSSW_7_1_X.

71X - update RelVal input for AK4 migration

It involves the following packages:

JetMETCorrections/Type1MET
PhysicsTools/PatAlgos

@nclopezo, @vadler, @cmsbuild, @Degano, @monttj can you please review it and eventually sign? Thanks.
@TaiSakuma, @nhanvtran this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@vadler
Copy link
Author

vadler commented May 9, 2014

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes or unless it breaks tests. @nclopezo, @ktf can you please take care of it?

davidlange6 added a commit that referenced this pull request May 10, 2014
@davidlange6
Merge pull request #3793 from vadler/71X-updateRelValInputForAK4Migra…
ac5bfa3 
…tion

71X - update RelVal input for AK4 migration
@davidlange6 davidlange6 merged commit ac5bfa3 into cms-sw:CMSSW_7_1_X May 10, 2014
@slava77 slava77 mentioned this pull request May 10, 2014
Merged
@ktf
Copy link
Contributor

ktf commented May 10, 2014

Looks like more is needed to fix this. There is a bunch of workflows in the latest IB which seems to fail due to ak4.

@vadler
Copy link
Author

vadler commented May 11, 2014

This fixed the add-on tests:
https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc6_amd64_gcc481/CMSSW_7_1_X_2014-05-10-0200/addOnTests/logs/cmsDriver-pat1_cmsRun__build_cmsbuild_jenkins-workarea_workspace_validatation-CMSSW_7_1_X-slc6_amd64_gcc481_cms_slc6_amd64_gcc481_cms_cmssw-patch_CMSSW_7_1_X_2014-05.log
vs.
https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc6_amd64_gcc481/CMSSW_7_1_X_2014-05-10-1400/addOnTests/logs/cmsDriver-pat1_cmsRun__build_cmsbuild_jenkins-workarea_workspace_validatation-CMSSW_7_1_X-slc6_amd64_gcc481_cms_slc6_amd64_gcc481_cms_cmssw-patch_CMSSW_7_1_X_2014-05.log

I didn't (and I won't) do anything on the matrix.

@ktf
Copy link
Contributor

ktf commented May 11, 2014

Ah, ok. Thanks for the reminder...

@vadler vadler deleted the 71X-updateRelValInputForAK4Migration branch May 21, 2014 11:28
TaiSakuma added a commit to TaiSakuma/cmssw that referenced this pull request Jul 23, 2014
@TaiSakuma
update test input files in PhysicsTools/PatAlgos
916eba4 
This update fixes the error *runtestPhysicsToolsPatAlgos* in cms-sw#4709.

The previous update was at cms-sw#3793.

I made this change interactively on github with a web browser.
@TaiSakuma TaiSakuma mentioned this pull request Jul 23, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
analysis-approved comparison-pending fully-signed tests-pending
Projects
None yet
Milestone
CMSSW_7_1_0_pre8
Development

Successfully merging this pull request may close these issues.
4 participants
@vadler @cmsbuild @ktf @davidlange6