-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change the naming convention of CaloMETs #4709
Conversation
…eFlow.metBenchmark_cff
…uNu.wmunusProducer_cfi
…1MET.correctedMet_cff
…1MET.correctionTermsCaloMet_cff
A new Pull Request was created by @TaiSakuma (Tai Sakuma) for CMSSW_7_2_X. change the naming convention of CaloMETs It involves the following packages: DQM/Physics @Dr15Jones, @StoyanStoynev, @danduggan, @cmsdoxy, @rovere, @monttj, @cmsbuild, @nclopezo, @deguio, @slava77, @vadler, @Degano, @ojeda, @ktf can you please review it and eventually sign? Thanks. |
-1 Tested at: fe485cd ---> test testJetMETCorrectionsType1MET had ERRORS you can see the results of the tests here: |
This PR seems to need a few more signatures. Is it ok to merge this PR? |
Hello. Is it possible to merge this PR, please, unless anyone has further comments? |
+1 |
Looks like core signature comes from FWCore/GuiBrowser. Maybe it should be moved to have an analysis only signature? |
Change the naming convention of CaloMETs
Continuing from #4114, this PR removes "corMetGlobalMuons" from the RECO sequence and the event contents of RECO and AOD. The new name is "caloMetM", which was already added to RECO and AOD at #4114 and included in CMSSW_7_2_0_pre1. This PR also replaces "corMetGlobalMuons" with "caloMetM" in various files.