-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[12_3_X] Bugfixes for DQM/BeamMonitor #37802
[12_3_X] Bugfixes for DQM/BeamMonitor #37802
Conversation
A new Pull Request was created by @francescobrivio for CMSSW_12_3_X. It involves the following packages:
@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
type bug-fix |
backport of #37801 |
test parameters:
|
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5dd922/24448/summary.html Comparison SummarySummary:
|
+1 tested at P5 |
Pull request #37802 was updated. @ggovi, @malbouis, @tvami, @francescobrivio can you please check and sign again. |
+db |
This pull request is fully signed and it will be integrated in one of the next CMSSW_12_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1
|
PR description:
Backport of #37801 to 12_3_X.
This PR fixes two bugs introduced in #37614:
logToDb_
flag fromonlineDbService_->lockRecords()
andonlineDbService_->releaseLocks()
as this flag is only meant to affect the logging, not the locking of recordsloggerActive_
) to avoid callingonlineDbService_->logger().end()
in caseonlineDbService_->logger().start()
was never calledPR validation:
Backport:
Backport of #37801
FYI @gennai @dzuolo @ggovi