Bugfixes for DQM/BeamMonitor

[francescobrivio]

PR description:

This PR fixes two bugs introduced in #37614:

• Remove the logToDb_ flag from onlineDbService_->lockRecords() and onlineDbService_->releaseLocks() as this flag is only meant to affect the logging, not the locking of records
• Add a flag (loggerActive_) to avoid calling onlineDbService_->logger().end() in case onlineDbService_->logger().start() was never called

PR validation:

Code compiles

Backport:

Not a backport, but a backport for 12_3_X will be provided soon.

FYI @gennai @dzuolo @ggovi

[francescobrivio]

type bug-fix

[francescobrivio]

test parameters:

• addpkg = DQM/Integration

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37801/29714

• This PR adds an extra 28KB to repository

[cmsbuild]

A new Pull Request was created by @francescobrivio for master.

It involves the following packages:

• DQM/BeamMonitor (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[francescobrivio]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fda843/24447/summary.html
COMMIT: a819e70
CMSSW: CMSSW_12_4_X_2022-05-04-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37801/24447/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
39434.501 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3700548
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3700518
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 205 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[emanueleusai]

+1

[cmsbuild]

Pull request #37801 was updated. @ggovi, @malbouis, @tvami, @francescobrivio can you please check and sign again.

[francescobrivio]

+1

Thanks @emanueleusai!
Was the 12_3_X backport already tested in online P5 playback system?

[emanueleusai]

no we are testing now

[tvami]

+db

• I understand from the backport PR that the tests at P5 have finished

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

• Tested at P5, see [12_3_X] Bugfixes for DQM/BeamMonitor #37802 (comment)