Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add D88 DD4hep wf to relval_2026 #37079

Merged
merged 1 commit into from
Feb 28, 2022
Merged

Conversation

srimanob
Copy link
Contributor

PR description:

This PR is to add D88 ttbar dd4hep workflow (39434.911) to relval_2026.

PR validation:

Local test with #37078 and #37005, the workflow run fine.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Not a backport and no need of backport.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37079/28553

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @srimanob (Phat Srimanobhas) for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv, upgrade)

@jordan-martins, @bbilin, @wajidalikhan, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen can you please review it and eventually sign? Thanks.
@makortel, @kpedro88, @Martin-Grunewald, @missirol, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@srimanob
Copy link
Contributor Author

test parameters:

@srimanob
Copy link
Contributor Author

@cmsbuild please test

@srimanob
Copy link
Contributor Author

@cmsbuild please abort

@srimanob
Copy link
Contributor Author

test parameters:

@srimanob
Copy link
Contributor Author

test parameters:

@srimanob
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-52f08a/22700/summary.html
COMMIT: fed96fb
CMSSW: CMSSW_12_3_X_2022-02-27-0000/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37079/22700/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-52f08a/39434.911_TTbar_14TeV+2026D88_DD4hep+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 4001143
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4001113
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 204 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@kskovpen
Copy link
Contributor

+pdmv

@srimanob
Copy link
Contributor Author

srimanob commented Feb 27, 2022

The PR test result is as expected. There is no change in existing Phase-2 DDD wfs. The new DD4hep phase-2 D88 workflow runs until the end, with error/warning message as reported in #36837 (comment)

Digi-HLT step:

%MSG-e HcalDigitizer:  MixingModule:mix 27-Feb-2022 15:53:15 CET Run: 1 Event: 1
bad hcal id found in digitizer. Skipping 1161838646 (HE -16,54,4)

RECO:

%MSG-w HcalDetId:  HcalDigisValidation:AllHcalDigisValidation  27-Feb-2022 16:03:20 CET Run: 1 Event: 1
HcalDetID(SimHit) presents conflicting information. Depth: 4, iphi: 54, ieta: -16. Max depth from geometry is: 0. TestNumber = 1

@perrotta
Copy link
Contributor

The PR test result is as expected. There is no change in existing Phase-2 wfs. The new DD4hep phase-2 workflow runs until the end, with error/warning message as reported in #36837 (comment)

Digi-HLT step:

%MSG-e HcalDigitizer:  MixingModule:mix 27-Feb-2022 15:53:15 CET Run: 1 Event: 1
bad hcal id found in digitizer. Skipping 1161838646 (HE -16,54,4)

RECO:

%MSG-w HcalDetId:  HcalDigisValidation:AllHcalDigisValidation  27-Feb-2022 16:03:20 CET Run: 1 Event: 1
HcalDetID(SimHit) presents conflicting information. Depth: 4, iphi: 54, ieta: -16. Max depth from geometry is: 0. TestNumber = 1

@cms-sw/hcal-dpg-l2 could you please have a look?

@srimanob
Copy link
Contributor Author

+Upgrade

This PR will make Phase-2 D88 DD4hep wf runs until complete. Merging it, together with #37078 and #37005, will enable us to make central validation, code clean up, updated config(s) and XML(s).

I will open the issue for HCAL.

PR test result is as expected as mentioned in #37079 (comment)

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants