Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comparison of DDD and DD4hep in Phase-2 Worflow #37087

Closed
srimanob opened this issue Feb 28, 2022 · 5 comments
Closed

Comparison of DDD and DD4hep in Phase-2 Worflow #37087

srimanob opened this issue Feb 28, 2022 · 5 comments

Comments

@srimanob
Copy link
Contributor

srimanob commented Feb 28, 2022

This issue is to follow up on difference, warning, error of DD4hep phase-2 workflows. Currently, the DD4hep can run on D88 (and other wfs. with M10). All remaining showstopper mentioned in #36837 seems to be solved using 3 PRs (#37005, #37078, #37079)

Some code review, clean up, debugging may take sometimes. However, the workflow can run until finish using [1].

Current issue (as of 28 Feb)

(1) Warning/Error message of HCAL in all events
Message in DIGI step:

%MSG-e HcalDigitizer:  MixingModule:mix 27-Feb-2022 11:23:14 CET Run: 1 Event: 3
bad hcal id found in digitizer. Skipping 1161838639 (HE -16,47,4)
%MSG

Message in RECO step:

%MSG-w HcalDetId:  HcalDigisValidation:AllHcalDigisValidation  27-Feb-2022 11:30:04 CET Run: 1 Event: 9
HcalDetID(SimHit) presents conflicting information. Depth: 4, iphi: 53, ieta: 16. Max depth from geometry is: 0. TestNumber = 1
%MSG

(2) Difference shows up in HGCAL DQM, e.g.
SimClusters/ticlSimTracksters
HitCalibration
overlay
where
.Black: D88 DDD Private
.Blue: D88 DD4hep Private
.Orange: DDD D77 central (12_3_0_pre5) <<== maybe it does not make sense to compare D77 here, just to make complete picture
.Red: DDD D88 central (12_3_0_pre5)
Note: This is done with private production. The agreement can be seen between DDD D88 official (red) and private (black).

DQM comparison for all is at https://tinyurl.com/ycg33avb

[1]

cmsrel CMSSW_12_3_X_2022-02-26-1100
cd CMSSW_12_3_X_2022-02-26-1100/src/
cmsenv
git cms-merge-topic srimanob:123_L1TDD4HepWf
git cms-merge-topic srimanob:123_FixPhase2DTSpecsFilter
scram b -j 8
runTheMatrix.py --what upgrade -l 39434.911 -t 8 --wm init
@cmsbuild
Copy link
Contributor

A new Issue was created by @srimanob Phat Srimanobhas.

@Dr15Jones, @perrotta, @dpiparo, @makortel, @smuzaffar, @qliphy can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@makortel
Copy link
Contributor

assign geometry,upgrade

@cmsbuild
Copy link
Contributor

New categories assigned: geometry,upgrade

@cvuosalo,@mdhildreth,@AdrianoDee,@ianna,@Dr15Jones,@srimanob,@makortel,@civanch you have been requested to review this Pull request/Issue and eventually sign? Thanks

@srimanob
Copy link
Contributor Author

@cms-sw/hcal-dpg-l2
(Parallel with email, sorry. I just realize that I never ping you on git before)

@srimanob
Copy link
Contributor Author

srimanob commented Nov 3, 2022

Seem the issue of HCAL DetID is fixed in #39967

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants