Add HiGenEvent object to heavy-ion miniAOD event content

[mandrenguyen]

PR description:

The HIGenEvent object stores a few gen-level variables that are relevant for heavy ion collisions. It's stored in AOD, we would like to keep it for miniAOD, too. The size of the object is negligible

PR validation:

Tested w/ wf 159

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36961/28316

• This PR adds an extra 16KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File PhysicsTools/PatAlgos/python/slimming/MicroEventContent_cff.py modified in PR(s): Refactoring gen weight storage in EDM + Nano integration #32167, Adding JPTjets to MiniAOD #36335

[cmsbuild]

A new Pull Request was created by @mandrenguyen (Matthew Nguyen) for master.

It involves the following packages:

• PhysicsTools/PatAlgos (reconstruction)

@jpata, @cmsbuild, @clacaputo, @slava77 can you please review it and eventually sign? Thanks.
@AlexDeMoor, @rappoccio, @gouskos, @jdolen, @JyothsnaKomaragiri, @ahinzmann, @schoef, @emilbols, @jdamgov, @mbluj, @nhanvtran, @gkasieczka, @hatakeyamak, @gpetruc, @azotz, @mariadalfonso, @demuller, @andrzejnovak, @seemasharmafnal, @mmarionncern this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[jpata]

@cmsbuild please test

[jpata]

For posterity, can you post some more detailed information about the size?

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b9a622/22432/summary.html
COMMIT: d7a114d
CMSSW: CMSSW_12_3_X_2022-02-14-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36961/22432/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 5 differences found in the comparisons
• DQMHistoTests: Total files compared: 46
• DQMHistoTests: Total histograms compared: 3764435
• DQMHistoTests: Total failures: 13
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3764399
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 45 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 193 log files, 42 edm output root files, 46 DQM output files
• TriggerResults: no differences found

[jpata]

assign xpog

[cmsbuild]

New categories assigned: xpog

@mariadalfonso,@gouskos,@fgolf you have been requested to review this Pull request/Issue and eventually sign? Thanks

[mandrenguyen]

@jpata It's just a few floats, I think. 3 kb per event if I understand the output of edmDumpEventSize correctly. It's near the bottom in the list of collections. Should be negligible.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36961/28386

• This PR adds an extra 16KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File PhysicsTools/PatAlgos/python/slimming/MicroEventContent_cff.py modified in PR(s): Refactoring gen weight storage in EDM + Nano integration #32167, Adding JPTjets to MiniAOD #36335

[cmsbuild]

Pull request #36961 was updated. @gouskos, @clacaputo, @cmsbuild, @fgolf, @slava77, @jpata, @mariadalfonso can you please check and sign again.

[clacaputo]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b9a622/22512/summary.html
COMMIT: 0809418
CMSSW: CMSSW_12_3_X_2022-02-18-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36961/22512/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 14 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3965143
• DQMHistoTests: Total failures: 25
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3965095
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 48 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 204 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[clacaputo]

@jpata It's just a few floats, I think. 3 kb per event if I understand the output of edmDumpEventSize correctly. It's near the bottom in the list of collections. Should be negligible.

Hi @mandrenguyen , on how many events have you performed this measurement?

Do you have a reference size of an event for HI?

[clacaputo]

Hello @mandrenguyen , any update on this #36961 (comment)?
Thanks

[mandrenguyen]

@clacaputo The added size is negligible. I suggest just running wf 159 to check it.

[mandrenguyen]

The ratio for 1 event in 159 is 2104127./2103802. = 1.0001545
wf 159 runs peripheral events so lighter than the average PbPb event. In our normal embedded MC this extra collection will be even more negligible.

[clacaputo]

+reconstruction

• no reco changes expected or observed
• the event size increase measured is negligible Add HiGenEvent object to heavy-ion miniAOD event content #36961 (comment)

[mariadalfonso]

+xpog

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1