Adding JPTjets to MiniAOD #36335

kodolova · 2021-12-02T14:09:55Z

PR description:

The code adds JPT jets to MiniAOD. It was reported at Jetmet meetings:
https://indico.cern.ch/event/1010496/contributions/4241123/attachments/2194135/3709198/jetmet22022021.pdf
https://indico.cern.ch/event/1072389/contributions/4509543/attachments/2304437/3920302/jmar07092021.pdf
2 collections are added: JPT jets and Calojets that are the source of JPTJets but are absent in slimmedCaloJets. The addional CaloJet collection is needed for (re)-calibration of JPTJets at MiniAOD.

PR validation:

scram b runtests - only as GEN-SIM-RECO file was as input cmsRun ${LOCAL_TEST_DIR}/patMiniAOD_standard_cfg.py || die 'Failure using patMiniAOD_standard_cfg.py' $?
runTheMatrix.py -l limited -i all --ibeos as it is.
/afs/cern.ch/work/k/kodolova/public/HMUMUBB/CMSSW_12_2_X_2021-12-01-1100/src

if this PR is a backport please specify the original PR and why you need to backport that PR:

Before submitting your pull requests, make sure you followed this checklist:

verify that the PR is really intended for the chosen branch
verify that changes follow CMS Naming, Coding, And Style Rules
verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

cmsbuild · 2021-12-02T14:16:14Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36335/27081

This PR adds an extra 20KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-checks:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36335/27081/code-checks.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36335/27081/code-checks.patch | patch -p1
You can also run scram build code-checks to apply code checks directly
code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36335/27081/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36335/27081/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2021-12-02T14:38:35Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36335/27083

This PR adds an extra 20KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36335/27083/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36335/27083/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2021-12-02T14:50:43Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36335/27086

This PR adds an extra 20KB to repository

cmsbuild · 2021-12-02T14:51:04Z

A new Pull Request was created by @kodolova (kodolova) for master.

It involves the following packages:

PhysicsTools/PatAlgos (reconstruction)

@jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@AlexDeMoor, @rappoccio, @gouskos, @jdolen, @JyothsnaKomaragiri, @ahinzmann, @schoef, @emilbols, @jdamgov, @mbluj, @nhanvtran, @gkasieczka, @hatakeyamak, @gpetruc, @azotz, @mariadalfonso, @demuller, @andrzejnovak, @seemasharmafnal, @mmarionncern this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

slava77 · 2021-12-02T16:22:35Z

@cmsbuild please test

slava77 · 2021-12-02T16:45:20Z

allow @clacaputo test rights

cmsbuild · 2021-12-02T17:46:06Z

-1

Failed Tests: RelVals RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8761bd/20944/summary.html
COMMIT: 64dbfc1
CMSSW: CMSSW_12_2_X_2021-12-02-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36335/20944/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

158.01

----- Begin Fatal Exception 02-Dec-2021 17:52:07 CET-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'MINIAODSIMoutput_step'
   [2] Prefetching for module PoolOutputModule/'MINIAODSIMoutput'
   [3] Calling method for module JPTJetSlimmer/'slimmedJPTJets'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for a container with elements of type: reco::JPTJet
Looking for module label: JetPlusTrackZSPCorJetAntiKt4
Looking for productInstanceName: 

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

312.0

----- Begin Fatal Exception 02-Dec-2021 17:58:27 CET-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'MINIAODSIMoutput_step'
   [2] Prefetching for module PoolOutputModule/'MINIAODSIMoutput'
   [3] Calling method for module JPTJetSlimmer/'slimmedJPTJets'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for a container with elements of type: reco::JPTJet
Looking for module label: JetPlusTrackZSPCorJetAntiKt4
Looking for productInstanceName: 

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

RelVals-INPUT

140.5611140.5611_RunHI2018AOD+RunHI2018AOD+REMINIAODHID18+HARVESTHI18MINIAOD/step2_RunHI2018AOD+RunHI2018AOD+REMINIAODHID18+HARVESTHI18MINIAOD.log
158.01158.01_HydjetQ_reminiaodPbPb2018_INPUT+HydjetQ_reminiaodPbPb2018_INPUT+REMINIAODHI2018PPRECOMB+HARVESTHI2018PPRECOMINIAOD/step2_HydjetQ_reminiaodPbPb2018_INPUT+HydjetQ_reminiaodPbPb2018_INPUT+REMINIAODHI2018PPRECOMB+HARVESTHI2018PPRECOMINIAOD.log

kodolova · 2021-12-02T20:16:13Z

I do not know how to perform in this case.
The problem is that some of root files used by matrix test does not have collection in GEN-SIM-RECO:
vectorreco::CaloJet "JetPlusTrackZSPCorJetAntiKt4" "" "RECO"
vectorreco::JPTJet "JetPlusTrackZSPCorJetAntiKt4" "" "RECO"
In principle, one can add to test-python:
process.load('RecoJets.Configuration.RecoJPTJets_cff')
process.p01=cms.Path(process.JetPlusTrackCorrections)
process.schedule = cms.Schedule(process.p01,
But I can do it only in my private tests...

kodolova · 2021-12-03T11:16:30Z

Dear Collegueas,
Could you advice? These 2 errors are due-to absence of JetPlusTrack collection in Heavy Ions RECO (these are Heavy Ion reco chains). RecoHI/HiJetAlgos/python/HiRecoJets_cff.py does not have JetPlusTrack production chain. Although the version of JetPlusTrack producer for HIN exists it was never used in production. For the moment we work with JPT and need it for pp collisions. what should I do???

cmsbuild · 2022-07-11T18:48:54Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8761bd/26136/summary.html
COMMIT: 2c8d455
CMSSW: CMSSW_12_5_X_2022-07-11-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36335/26136/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 3655970
DQMHistoTests: Total failures: 8
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3655940
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
Checked 208 log files, 45 edm output root files, 50 DQM output files
TriggerResults: no differences found

clacaputo · 2022-07-13T14:14:49Z

+reconstruction

JPTJets added to MiniAOD collection:
- only the small part that is seeded by Calojet with pt<20GeV and Trackjets is kept
- the rest can be reconstructed from MiniAOD Calojets and tracks
event size increase measured in ttbar is about 0.06%

mariadalfonso · 2022-07-25T06:59:24Z

+xpog

no objection to this addition, since has a minimal impact on the size of mini.

qliphy · 2022-07-25T09:38:30Z

please test
to refresh the results

cmsbuild · 2022-07-25T14:00:47Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8761bd/26433/summary.html
COMMIT: 2c8d455
CMSSW: CMSSW_12_5_X_2022-07-24-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36335/26433/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 6 differences found in the comparisons
DQMHistoTests: Total files compared: 51
DQMHistoTests: Total histograms compared: 3667670
DQMHistoTests: Total failures: 14
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3667634
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
Checked 210 log files, 47 edm output root files, 51 DQM output files
TriggerResults: no differences found

clacaputo · 2022-08-04T13:58:11Z

Hi @kodolova , while we are waiting for analysis sign, could you please edit the PR description? I've just noted that there are some format issues.
@qliphy , what is the procedure with analysis-pending? I can't find the relevant l2 tag on github

qliphy · 2022-08-07T01:16:47Z

Hi @kodolova , while we are waiting for analysis sign, could you please edit the PR description? I've just noted that there are some format issues. @qliphy , what is the procedure with analysis-pending? I can't find the relevant l2 tag on github

@clacaputo analysis signature is basically on ORP side.
@kodolova Please edit the description as suggested.

qliphy · 2022-08-07T01:16:54Z

please test

cmsbuild · 2022-08-07T05:49:01Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8761bd/26682/summary.html
COMMIT: 2c8d455
CMSSW: CMSSW_12_5_X_2022-08-06-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36335/26682/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 51
DQMHistoTests: Total histograms compared: 3691612
DQMHistoTests: Total failures: 2
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3691588
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
Checked 212 log files, 49 edm output root files, 51 DQM output files
TriggerResults: no differences found

qliphy · 2022-08-13T05:57:25Z

+1
@kodolova Please edit the description as suggested above

qliphy · 2022-08-13T05:58:10Z

merge

santocch · 2022-09-06T07:05:19Z

+1

cmsbuild added this to the CMSSW_12_2_X milestone Dec 2, 2021

cmsbuild added code-checks-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Dec 2, 2021

cmsbuild added code-checks-rejected code-checks-pending and removed code-checks-pending code-checks-rejected labels Dec 2, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Dec 2, 2021

cmsbuild added tests-started and removed tests-pending labels Dec 2, 2021

cmsbuild added the allow-clacaputo label Dec 2, 2021

cmsbuild added tests-rejected and removed tests-started labels Dec 2, 2021

cmsbuild added the tests-started label Jul 11, 2022

cmsbuild added tests-approved and removed tests-started labels Jul 11, 2022

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Jul 13, 2022

cmsbuild added xpog-approved and removed xpog-pending labels Jul 25, 2022

cmsbuild added tests-started and removed tests-approved labels Jul 25, 2022

cmsbuild added tests-approved and removed tests-started labels Jul 25, 2022

cmsbuild added tests-started and removed tests-approved labels Aug 7, 2022

cmsbuild added tests-approved and removed tests-started labels Aug 7, 2022

cmsbuild added orp-approved and removed orp-pending labels Aug 13, 2022

cmsbuild merged commit 226ef9f into cms-sw:master Aug 13, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding JPTjets to MiniAOD #36335

Adding JPTjets to MiniAOD #36335

kodolova commented Dec 2, 2021

cmsbuild commented Dec 2, 2021

cmsbuild commented Dec 2, 2021

cmsbuild commented Dec 2, 2021

cmsbuild commented Dec 2, 2021

slava77 commented Dec 2, 2021

slava77 commented Dec 2, 2021

cmsbuild commented Dec 2, 2021

kodolova commented Dec 2, 2021

kodolova commented Dec 3, 2021

cmsbuild commented Jul 11, 2022

clacaputo commented Jul 13, 2022

mariadalfonso commented Jul 25, 2022

qliphy commented Jul 25, 2022

cmsbuild commented Jul 25, 2022

clacaputo commented Aug 4, 2022

qliphy commented Aug 7, 2022

qliphy commented Aug 7, 2022

cmsbuild commented Aug 7, 2022

qliphy commented Aug 13, 2022

qliphy commented Aug 13, 2022

santocch commented Sep 6, 2022

Adding JPTjets to MiniAOD #36335

Adding JPTjets to MiniAOD #36335

Conversation

kodolova commented Dec 2, 2021

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Dec 2, 2021

cmsbuild commented Dec 2, 2021

cmsbuild commented Dec 2, 2021

cmsbuild commented Dec 2, 2021

slava77 commented Dec 2, 2021

slava77 commented Dec 2, 2021

cmsbuild commented Dec 2, 2021

RelVals

RelVals-INPUT

kodolova commented Dec 2, 2021

kodolova commented Dec 3, 2021

cmsbuild commented Jul 11, 2022

Comparison Summary

clacaputo commented Jul 13, 2022

mariadalfonso commented Jul 25, 2022

qliphy commented Jul 25, 2022

cmsbuild commented Jul 25, 2022

Comparison Summary

clacaputo commented Aug 4, 2022

qliphy commented Aug 7, 2022

qliphy commented Aug 7, 2022

cmsbuild commented Aug 7, 2022

Comparison Summary

qliphy commented Aug 13, 2022

qliphy commented Aug 13, 2022

santocch commented Sep 6, 2022