check both algo and originalAlgo in electron track isolation calculators (bp of #36364)

[slava77]

backport of #36364

requested in https://its.cern.ch/jira/browse/PDMVRELVALS-130

[cmsbuild]

A new Pull Request was created by @slava77 (Slava Krutelyov) for CMSSW_12_2_X.

It involves the following packages:

• RecoEgamma/EgammaIsolationAlgos (reconstruction)

@jpata, @cmsbuild, @clacaputo, @slava77 can you please review it and eventually sign? Thanks.
@Sam-Harper, @jainshilpi, @lgray, @sobhatta, @afiqaize, @wrtabb, @varuns23, @ram1123 this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

• Backported from check both algo and originalAlgo in electron track isolation calculators #36364

[slava77]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-de6c51/22195/summary.html
COMMIT: c0aec63
CMSSW: CMSSW_12_2_X_2022-02-03-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36876/22195/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 66 differences found in the comparisons
• DQMHistoTests: Total files compared: 42
• DQMHistoTests: Total histograms compared: 3250600
• DQMHistoTests: Total failures: 137
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3250440
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 41 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 177 log files, 37 edm output root files, 42 DQM output files
• TriggerResults: no differences found

[perrotta]

urgent

[perrotta]

• Reco comparison results: 66 differences found in the comparisons

@cms-sw/reconstruction-l2 please notice that the changes are expected
No production started yet with 12_2_X, and therefore the "no reco change" rule does not apply (yet) to the backports into 12_2_X

[jpata]

+reconstruction

• bugfix and a direct backport of check both algo and originalAlgo in electron track isolation calculators #36364
• changes only in electron iso and downstream
• the no change rule is not relevant here as suggested above (production not yet started, and moreover this change was requested by PPD)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1