-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
check both algo and originalAlgo in electron track isolation calculators #36364
check both algo and originalAlgo in electron track isolation calculators #36364
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36364/27126
|
A new Pull Request was created by @slava77 (Slava Krutelyov) for master. It involves the following packages:
@jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6f4b09/20988/summary.html Comparison SummarySummary:
|
these are, as expected from the code changes, coming from small increases in the track isolation e.g in DoubleEG 2017C wf 136.793 @swagata87 |
Hello Slava,
these checks are normally quite quick, and we expect to report back to you very soon (let's say 1-2 days). |
@cmsbuild please test
Thank you. Since I made this PR to get more consistent performance with/without mkFIt, you may want to consider the no-mkFIt variant for comparison as well. |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6f4b09/21125/summary.html Comparison SummarySummary:
|
@swagata87 |
+reconstruction
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
…IsoOriginalAlgo check both algo and originalAlgo in electron track isolation calculators (bp of #36364)
similar to #35892, I'm proposing to check both the algo and the originalAlgo in track selections for EGM
@cms-sw/egamma-pog-l2
this was prompted by the observations in the EXO validation https://indico.cern.ch/event/1102815/
https://indico.cern.ch/event/1102815/contributions/4639510/attachments/2357228/4025487/W%27toenu%20mkFit%20vaildation%20study%20Run3.pdf
(page 5)