Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[11_1_X] Protect storage accounting UDP messages from NaN, and Use StatisticsSenderService for all framework files #36357

Merged
merged 9 commits into from
Dec 10, 2021
Merged

[11_1_X] Protect storage accounting UDP messages from NaN, and Use StatisticsSenderService for all framework files #36357

merged 9 commits into from
Dec 10, 2021

Conversation

makortel
Copy link
Contributor

@makortel makortel commented Dec 3, 2021 •
edited
Loading

PR description:

This PR is a combined backport of #35362 and #35505, following requests in #29412 and #36349. Includes also #36379 and #36403 as further fix and cleanup.

PR validation:

Unit tests pass

@Dr15Jones @makortel
Protect storage accounting UDP messages from NaN
e8fbb9a 
NaN's were being reported from the values computed using sqrt. This most likely was from the different variables not being updated atomically together.
@Dr15Jones @makortel
Report only once when trying to open file
b579434 
Previously, each try to open the file using a different PFN would report an open attempt for the same LFN. This meant we could have multiple opens but only one close for a given LFN.
@Dr15Jones @makortel
StatisticsSenderService now requires LFN or URL
73fb7e2 
When sending information to the StatisticsSenderService, the file LFN or URL must be supplied.
@Dr15Jones @makortel
Report all framework files to StatisticsSenderService
01a9149 
Send statistics for primary, secondary, and embedded files.
The aggregate file statistics are only reset on primary file close boundaries to keep the behavior the same as previous.
Changed all calls to closeFile_() to be the new closeFile()
@Dr15Jones @makortel
Changed SecondaryProducer to be a one::EDProducer
4362e1b
@Dr15Jones @makortel
Added unit test for StatisticsSenderService
f6c944c
@Dr15Jones @makortel
Pass InputType to StatisticsSenderService
55bb971 
Now broadcasts how the file is used.
@makortel makortel mentioned this pull request Dec 3, 2021
Closed
11 tasks
@cmsbuild cmsbuild added this to the CMSSW_11_1_X milestone Dec 3, 2021
@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2021

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_11_1_X.

It involves the following packages:

  • IOPool/Input (core)
  • IOPool/SecondaryInput (core)
  • IOPool/TFileAdaptor (core)
  • Utilities/StorageFactory (core)
  • Utilities/XrdAdaptor (core)

@cmsbuild, @smuzaffar, @Dr15Jones, @makortel can you please review it and eventually sign? Thanks.
@wddgit this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor Author

makortel commented Dec 3, 2021

@cmsbuild, please test

@makortel
Copy link
Contributor Author

makortel commented Dec 3, 2021

backport

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6f4686/20976/summary.html
COMMIT: 55bb971
CMSSW: CMSSW_11_1_X_2021-11-28-0000/slc7_amd64_gcc820
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36357/20976/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 7 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2784828
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2784776
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 31 edm output root files, 36 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2021

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@makortel
Copy link
Contributor Author

makortel commented Dec 6, 2021

hold

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2021

Pull request has been put on hold by @makortel
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@makortel
Copy link
Contributor Author

makortel commented Dec 9, 2021

Now including #36379 and #36403 too.

@makortel
Copy link
Contributor Author

makortel commented Dec 9, 2021

unhold

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2021

Pull request #36357 was updated. @cmsbuild, @smuzaffar, @Dr15Jones, @makortel can you please check and sign again.

@makortel
Copy link
Contributor Author

makortel commented Dec 9, 2021

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6f4686/21142/summary.html
COMMIT: 74f669c
CMSSW: CMSSW_11_1_X_2021-12-09-1100/slc7_amd64_gcc820
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36357/21142/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2784828
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2784776
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 31 edm output root files, 36 DQM output files
  • TriggerResults: no differences found

@makortel
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Dec 10, 2021

+1

@cmsbuild cmsbuild merged commit 44e69da into cms-sw:CMSSW_11_1_X Dec 10, 2021
@makortel makortel deleted the backportStatisticsSenderService_111x branch December 10, 2021 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
core-approved fully-signed orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_11_1_X
Development

Successfully merging this pull request may close these issues.
4 participants
@makortel @cmsbuild @qliphy @Dr15Jones