Use StatisticsSenderService for all framework files

[Dr15Jones]

PR description:

• Send StatisticsSenderService messages for primary, secondary and embedded files
• Added debug ability to StatisticsSenderService
• Added unit tests

PR validation:

Code compiles, framework unit tests pass.
I also tested locally using the trivial file catalog and explicitly root: designated input files.

resolves #34873

[Dr15Jones]

For backports, I'd only do the first 3 commits in this PR.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35505/25696

• This PR adds an extra 64KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Utilities/XrdAdaptor/src/XrdRequestManager.cc modified in PR(s): For async calls always store XrdCl::FileSystem with the response-handler. #35481, Backport XrootD 5.3.1 PR to master from DEVEL #34991

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

• IOPool/Input (core)
• IOPool/SecondaryInput (core)
• IOPool/TFileAdaptor (core)
• Utilities/StorageFactory (core)
• Utilities/XrdAdaptor (core)

@makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @wddgit this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-012c4a/19319/summary.html
COMMIT: 7786d20
CMSSW: CMSSW_12_1_X_2021-09-30-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35505/19319/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 10 differences found in the comparisons
• DQMHistoTests: Total files compared: 40
• DQMHistoTests: Total histograms compared: 3211080
• DQMHistoTests: Total failures: 12
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3211046
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 39 files compared)
• Checked 169 log files, 37 edm output root files, 40 DQM output files
• TriggerResults: no differences found

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35505/26035

• This PR adds an extra 68KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Utilities/XrdAdaptor/src/XrdRequestManager.cc modified in PR(s): For async calls always store XrdCl::FileSystem with the response-handler. #35481, Backport XrootD 5.3.1 PR to master from DEVEL #34991

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35505/26035/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35505/26035/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[makortel]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1