CSC L1T DQM 2D summary plots: Flip the two endcaps on the y-axis

[dildick]

PR description:

I presented #36226 at the CSC Weekly meeting https://indico.cern.ch/event/1101484/contributions/4634324/attachments/2356412/4022809/CSCDQM_SD_20211201.pdf. During the presentation I noticed that the endcaps are flipped on the y-axis. I realized it when I saw the 3-wide gap in ME-1/1 at chamber 9, 10 and 11. It should white for ME+1/1/9, ME+1/1/10, and ME+1/1/11.

In my study I excluded ME+1/1/9, ME+1/1/10, and ME+1/1/11 because there we had downloaded experimental firmware for the HL-LHC (https://twiki.cern.ch/twiki/bin/viewauth/CMS/CSCOTMB2018) in late 2018.

Basically I added a digi filter that I introduced earlier in #35717 after the CSC unpacker and before the CSC trigger emulator

      from EventFilter.CSCRawToDigi.cscDigiFilterDef_cfi import cscDigiFilterDef

      # clone the original producer
      process.preCSCDigis = process.muonCSCDigis.clone()

      # now apply the filter
      process.muonCSCDigis = cscDigiFilterDef.clone(
            stripDigiTag = "preCSCDigis:MuonCSCStripDigi",
            wireDigiTag = "preCSCDigis:MuonCSCWireDigi",
            compDigiTag = "preCSCDigis:MuonCSCComparatorDigi",
            alctDigiTag = "preCSCDigis:MuonCSCALCTDigi",
            clctDigiTag = "preCSCDigis:MuonCSCCLCTDigi",
            lctDigiTag = "preCSCDigis:MuonCSCCorrelatedLCTDigi",
            showerDigiTag = "preCSCDigis:MuonCSCShowerDigi",
            gemPadClusterDigiTag = "preCSCDigis:MuonGEMPadDigiCluster",
            maskedChambers = options.maskedChambers,
            selectedChambers = options.selectedChambers
      )

      # these 3 chambers had Phase-2 firmware loaded partially during Run-2
      # https://twiki.cern.ch/twiki/bin/viewauth/CMS/CSCOTMB2018
      process.muonCSCDigis.maskedChambers = [
            "ME+1/1/9", "ME+1/1/10", "ME+1/1/11"]

      process.unpacksequence = cms.Sequence(process.preCSCDigis * process.muonCSCDigis)

PR validation:

Tested on 10k events of Run 322022 (of 2018D).
CSC_dataVsEmul_CMS_Run_322022_postFlip.pdf

Screenshot after flipping the two endcaps:

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

@ptcox @zuoxunwu

[dildick]

I also modified DQM/L1TMonitor/src/L1TStage2Shower.cc @zuoxunwu because that code was my starting point

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36328/27068

• This PR adds an extra 20KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File DQM/L1TMonitor/src/L1TStage2Shower.cc modified in PR(s): (Un)packers for hadronic showers at the uGMT input and output #35627

[cmsbuild]

A new Pull Request was created by @dildick (Sven Dildick) for master.

It involves the following packages:

• DQM/L1TMonitor (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b6eb40/20925/summary.html
COMMIT: 2b4ddce
CMSSW: CMSSW_12_2_X_2021-12-01-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36328/20925/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 41
• DQMHistoTests: Total histograms compared: 3041955
• DQMHistoTests: Total failures: 194
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3041739
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 40 files compared)
• Checked 175 log files, 37 edm output root files, 41 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1
Flipped y-axis as expected

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

By the way, since endcap is only used to check whether it is equal 1 or not, a further simplification could be replacing L95 with

    int endcap = detId.endcap();

[perrotta]

+1