-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 2D TPG data-vs-emulation summary plots for L1T CSC DQM #36226
Add 2D TPG data-vs-emulation summary plots for L1T CSC DQM #36226
Conversation
If desired the 1D plots can be turned of with |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36226/26842
|
A new Pull Request was created by @dildick (Sven Dildick) for master. It involves the following packages:
@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0f0911/20726/summary.html Comparison SummarySummary:
|
@dildick alct_csctp_emul_summary_num and lct_csctp_emul_summary_num appear empty in all the WFs, despite your test plots looked fine. Do you think is just stats (workflows have 10 events only)? |
Yes, the "emul" summary plots indicate emulated ALCTs/CLCTs/LCTs without matching idea. Ideally this plot is completely empty, even at high statistics. Because then it means that there are no excess trigger primitives in the simulation. |
I understand thanks, I had interpreted them the other way around... |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
As requested by CSC DPG and by DQM conveners (#33085 (comment)), this PR adds a few 2D summary plots for the CSC TPG data-vs-emulation in the DQM. There are 6 plots, 2 for each object ALCT/CLCT/LCT. For each object I have a 2D plot that shows the efficiency to correctly emulate the data objects, and a plot that shows the percentage of emulated objects that do not have a data counterpart. Emulated and data objects are compared with an
operator==
function, or a custom equality function.PR validation:
Tested on 15k events of Run 322022. A few plots are shown below. Plots with 26k events can be seen here: #36046 (comment)
Plots
if this PR is a backport please specify the original PR and why you need to backport that PR:
N.A.
@ptcox @tahuang1991 @giovanni-mocellin