Add option for dimuon Delta R for HLTMuonDimuonL3Filter

[arsahasransu]

PR description:

• This PR is a development towards CMS Run3 HLT where we trigger events with soft muons in them. To get a reasonable rate, new kinematic constraints on the dimuon events need to be placed at the HLT.

• Added options to make a selection on the minimum angle required between L3 muons in the trigger

• This is based on the presentation at https://indico.cern.ch/event/1090283/#33-level-3-paths-for-singlet-t

• Sam James Harper noticed that error management in the module can be improved.

• It is ideal to throw an exception at the constructor level when that error renders the module of no use. This enable catching the error in the build phase instead of having to wait for a message from cmsRun.

PR validation:

• Standard set of checks performed at https://cms-sw.github.io/PRWorkflow.html were done and passed.
• A trigger was made with the suggested changes. We observed expected behavior from this trigger of interest.
• @missirol made a first round of review and corrections in a previous PR at Add option for invert mass window cut and Delta R for HLTMuonDimuonL3Filter #36250. I had to close this because of some major mistakes while trying to squash the commits together.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36267/26937

• This PR adds an extra 24KB to repository

[cmsbuild]

A new Pull Request was created by @arsahasransu (A.R.Sahasransu) for master.

It involves the following packages:

• HLTrigger/Muon (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Fedespring, @HuguesBrun, @calderona, @silviodonato, @abbiendi, @jhgoh, @Martin-Grunewald, @missirol, @sscruz, @CeliaFernandez, @trocino, @cericeci this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[missirol]

Just a comment: this change is correct, but it was already included #36005. The reason that's not showing up here is that this PR is based off 12_2_0_pre1, not 12_2_0_pre2 (which includes #36005), or a recent IB (e.g. CMSSW_12_2_X_2021-11-25-2300). In any case, it looks like git will merge changes correctly in the target branch (without touching what was done in #36005), so no further action is needed on this.

[missirol]

Suggested change

const std::vector<int> invertDiMuonMassSelection_; // condition to invert the invariant mass selection

[arsahasransu]

Since it was a small change to avoid pushing and pulling multiple times, I just made the change on my branch and pushed it directly.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36267/26959

• This PR adds an extra 16KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36267/26959/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36267/26959/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36267/26963

• This PR adds an extra 16KB to repository

[cmsbuild]

Pull request #36267 was updated. @cmsbuild, @missirol, @Martin-Grunewald can you please check and sign again.

[missirol]

In 76a7ee0, I still see the changes related to the "inverted mass cut", and in 5a4d863 the commit message contains a lot of unnecessary information. I think it's best to clean up the history of this PR. You can do this as follows:

scram p CMSSW CMSSW_12_2_X_2021-11-28-2300
cd CMSSW_12_2_X_2021-11-28-2300/src
eval `scram runtime -sh`
git cms-init
git cms-addpkg HLTrigger/Muon
git checkout -b mergeDimuonL3FilterModifs
git cherry-pick 76a7ee0621281385527b0961b2fe187ee81a6b82^..5a4d86368f1e48ebab2a9473e3652528dff28016 --no-commit -Xours
scram b code-checks
scram b code-format
scram b
git add -u :/
git commit -m 'Add option for dimuon min-DeltaR cut in HLTMuonDimuonL3Filter'
git push my-cmssw mergeDimuonL3FilterModifs -f

[arsahasransu]

@missirol I have run the above commands and pushed them to the PR. I am still to be adept at git.

[missirol]

No problem. Looks good now.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36267/26964

• This PR adds an extra 20KB to repository

[cmsbuild]

Pull request #36267 was updated. @cmsbuild, @missirol, @Martin-Grunewald can you please check and sign again.

[missirol]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c4db5d/20814/summary.html
COMMIT: 04b2f5b
CMSSW: CMSSW_12_2_X_2021-11-28-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36267/20814/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 42
• DQMHistoTests: Total histograms compared: 3247873
• DQMHistoTests: Total failures: 5
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3247845
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 41 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 177 log files, 37 edm output root files, 42 DQM output files
• TriggerResults: no differences found

[missirol]

+hlt

• adds option to apply a cut on dimuon min-DeltaR to the plugin HLTMuonDimuonL3Filter
• new option is disabled by default, and tests show no differences in outputs as expected
• was previously Add option for invert mass window cut and Delta R for HLTMuonDimuonL3Filter #36250, and part of the review was done there
• also includes some technical improvements (e.g. const class members)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1