Bugfix for mass-window cut in HLTMuonDimuonL3Filter

[vjmastra]

PR description:

PR to fix the bug in HLTMuonDimuonL3filter.cc
The module allows selection of separate mass windows for dimuon candidates,
but only the first mass window is considered because of the bug.
This affects for instance the HLT path HLT_DoubleMu4_LowMassNonResonantTrk_Displaced,
using [1.0, 2.9] U [4.0, 4.8]
Events in the windows other than the first are now considered

PR validation:

A trigger path for non resonant dimuons has been used for test
(config file: /afs/cern.ch/user/v/vmastrap/public/fix-dimu-mass-windows/hlt.py)
and run on EphemeralHLTPhysics dataset
(file list: /afs/cern.ch/user/v/vmastrap/public/fix-dimu-mass-windows/list_cff.py)
Events in the second mass window fire the trigger after the bug fix
(plot: /afs/cern.ch/user/v/vmastrap/public/fix-dimu-mass-windows/plot.pdf)

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36005/26440

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @vjmastra (Vincenzo) for master.

It involves the following packages:

• HLTrigger/Muon (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Fedespring, @HuguesBrun, @calderona, @silviodonato, @abbiendi, @jhgoh, @Martin-Grunewald, @missirol, @sscruz, @CeliaFernandez, @trocino, @cericeci this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[missirol]

please test

[missirol]

Tagging Muon-HLT contacts: @JanFSchulte @khaosmos93

[missirol]

type bugfix

[missirol]

@vjmastra, please improve the PR title, for example with "Bugfix for mass-window cut in HLTMuonDimuonL3Filter". Thanks.

[JanFSchulte]

@missirol I case this is needed: As Muon HLT contacts we endorse this PR and thank the authors for finding and fixing this bug.

[missirol]

Thanks, @JanFSchulte ; I just wanted to make sure MUO was in the loop.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c0a575/20274/summary.html
COMMIT: 93e777a
CMSSW: CMSSW_12_2_X_2021-11-04-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36005/20274/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @bsunanda Run3-gex98 Make use of esConsume in Geometry/CommonTopologies #36000
• @makortel Use esConsumes in ListIds and TrackingMaterialAnalyser #35993
• @mmusich Miscellaneous Alignment/OfflineValidation improvements #35983
• @bsunanda Phase2-hgx294X Update the scripts to validate HGCal geometry #35962
• @apsallid [HGCAL] makeHGCalValidationPlots.py crash due to python3 #35973

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c0a575/20274/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c0a575/20274/git-merge-result

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 42
• DQMHistoTests: Total histograms compared: 2901890
• DQMHistoTests: Total failures: 5
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2901862
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 41 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 177 log files, 37 edm output root files, 42 DQM output files
• TriggerResults: no differences found

[missirol]

The filter in question could use a cleanup to at least improve code readibility.
Otoh, I prefer not to delay the integration of this bugfix for purely technical changes (the latter could be done in a future PR).

[missirol]

+hlt

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1