Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AJJGenJetFilter to filter photon+2jets events at GenLevel #35981

Merged
merged 1 commit into from
Nov 9, 2021

Conversation

hbakhshi
Copy link
Contributor

@hbakhshi hbakhshi commented Nov 4, 2021

PR description:

Here is the accepted PR in the master branch:
#35547

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

we need the AJJGenJetFilter filter to produce some samples for the snowmass studies. the snowmass campaign is based on cmssw_11_0_x

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2021

A new Pull Request was created by @hbakhshi (Hamed Bakhshian) for CMSSW_11_0_X.

It involves the following packages:

  • GeneratorInterface/GenFilters (generators)

@SiewYan, @mkirsano, @Saptaparna, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez can you please review it and eventually sign? Thanks.
@alberto-sanchez, @mkirsano this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@agrohsje
Copy link

agrohsje commented Nov 4, 2021

please test

@hbakhshi
Copy link
Contributor Author

hbakhshi commented Nov 4, 2021

@agrohsje thanks a lot

@perrotta
Copy link
Contributor

perrotta commented Nov 4, 2021

backport of #35547

@perrotta
Copy link
Contributor

perrotta commented Nov 4, 2021

@hbakhshi could you please modify the title in order to have it a bit more descriptive (for example starting from the same title as #35547)?

@hbakhshi hbakhshi changed the title backporting of PR #35547 AJJGenJetFilter to filter photon+2jets events at GenLevel Nov 4, 2021
@hbakhshi
Copy link
Contributor Author

hbakhshi commented Nov 4, 2021

@perrotta done, please let me know if it is not fine yet

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3c4377/20255/summary.html
COMMIT: cdf7e44
CMSSW: CMSSW_11_0_X_2021-11-04-1100/slc7_amd64_gcc820
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35981/20255/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

The workflows 1001.0, 1000.0, 140.53, 136.85, 136.8311, 136.7611, 136.731, 4.22 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2793840
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2793498
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 30 edm output root files, 34 DQM output files
  • TriggerResults: no differences found

@SiewYan
Copy link
Contributor

SiewYan commented Nov 8, 2021

please test workflow 1001.0, 1000.0, 140.53, 136.85, 136.8311, 136.7611, 136.731, 4.22

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3c4377/20320/summary.html
COMMIT: cdf7e44
CMSSW: CMSSW_11_0_X_2021-11-07-0000/slc7_amd64_gcc820
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35981/20320/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2793840
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2793498
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 30 edm output root files, 34 DQM output files
  • TriggerResults: no differences found

@hbakhshi
Copy link
Contributor Author

hbakhshi commented Nov 9, 2021

Hello @SiewYan
Thanks for triggering the tests. It seems that all the tests are passed. What would be the next step for it to get approved.

@SiewYan
Copy link
Contributor

SiewYan commented Nov 9, 2021

Hello, from my side it looks good.

@SiewYan
Copy link
Contributor

SiewYan commented Nov 9, 2021

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2021

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Nov 9, 2021

+1

@cmsbuild cmsbuild merged commit 15a1e6d into cms-sw:CMSSW_11_0_X Nov 9, 2021
@Saptaparna
Copy link
Contributor

@qliphy and @perrotta: do you have plans of releasing a new version of 11_X, so we can submit this Snowmass request?

@qliphy
Copy link
Contributor

qliphy commented Nov 12, 2021

@Saptaparna Yes, we will make a new 11_1_X.
We are waiting for #35939

@hbakhshi
Copy link
Contributor Author

Hi @qliphy and @perrotta. Any news regarding the new release? We need this filter very urgently for the sample production. Any help is really appreciated

@perrotta
Copy link
Contributor

Hi @qliphy and @perrotta. Any news regarding the new release? We need this filter very urgently for the sample production. Any help is really appreciated

#35939 is still wating for the requested updates to be implemented...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants