AJJGenJet filter added. #35547

hbakhshi · 2021-10-05T23:04:32Z

PR description:

A new filter added to the GeneratorInterface/GenFilters package. It is specially designed to select events with 1 photon + 2VBF jets. cuts on photon and jet are completely configurable.

PR validation:

the filter tested on run-2 and snowmass gridpacks and fragments.

if this PR is a backport please specify the original PR and why you need to backport that PR:

this filter is going to be used to generate vbf+photon samples for run2 and snowmass analyses

Before submitting your pull requests, make sure you followed this checklist:

verify that the PR is really intended for the chosen branch
verify that changes follow CMS Naming, Coding, And Style Rules
verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

cmsbuild · 2021-10-05T23:04:52Z

@hbakhshi, CMSSW_12_1_X branch is closed for direct updates. cms-bot is going to move this PR to master branch.
In future, please use cmssw master branch to submit your changes.

cmsbuild · 2021-10-05T23:10:32Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35547/25777

This PR adds an extra 20KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35547/25777/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35547/25777/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2021-10-05T23:40:26Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35547/25779

This PR adds an extra 20KB to repository

cmsbuild · 2021-10-05T23:40:55Z

A new Pull Request was created by @hbakhshi (Hamed Bakhshian) for master.

It involves the following packages:

GeneratorInterface/GenFilters (generators)

@SiewYan, @mkirsano, @Saptaparna, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez can you please review it and eventually sign? Thanks.
@alberto-sanchez, @mkirsano this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

Dr15Jones · 2021-10-06T02:28:36Z

GeneratorInterface/GenFilters/plugins/AJJGenJetFilter.h

+// class declaration
+//
+
+class AJJGenJetFilter : public edm::EDFilter {


Please use a thread friendly base class.

cmsbuild · 2021-10-06T09:48:22Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35547/25787

This PR adds an extra 20KB to repository
Found files with invalid states:
- GeneratorInterface/GenFilters/plugins/AJJGenJetFilter.h:
  - Added: a99b0a9
  - Modified: 09b7d9e
  - Deleted: ec83a8c

cmsbuild · 2021-10-06T09:48:43Z

Pull request #35547 was updated. @SiewYan, @mkirsano, @Saptaparna, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez can you please check and sign again.

Dr15Jones · 2021-10-06T13:32:15Z

GeneratorInterface/GenFilters/plugins/AJJGenJetFilter.cc

+};
+
+AJJGenJetFilter::AJJGenJetFilter(const edm::ParameterSet& iConfig)
+    : ptMin(iConfig.getUntrackedParameter<double>("minPt", 0)),


You do not need to add default values here since you already specify them in the fillDescriptions function

Also, shouldn’t these all be tracked parameters as you want to record what cuts were being used?

thanks for your comments, I have tried to address both of them

cmsbuild · 2021-10-18T14:54:01Z

Pull request #35547 was updated. @SiewYan, @mkirsano, @Saptaparna, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez can you please check and sign again.

SiewYan · 2021-10-18T16:00:26Z

please test workflow 514,552,554

cmsbuild · 2021-10-18T19:31:38Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fd1cc7/19718/summary.html
COMMIT: 4a701cf
CMSSW: CMSSW_12_1_X_2021-10-18-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35547/19718/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-fd1cc7/514.0_GGToHgg_NLO_Pow_13TeV_py8+GGToH_Pow_LHE_13TeV+Hadronizer_TuneCP5_13TeV_Hgg_powhegEmissionVeto_pythia8+HARVESTGEN2
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-fd1cc7/552.0_VHToHtt_NLO_Pow_13TeV_py8+VHToH_Pow_LHE_13TeV+Hadronizer_TuneCP5_13TeV_Htt_powhegEmissionVeto_pythia8+HARVESTGEN2
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-fd1cc7/554.0_VBFToH4l_NLO_Pow_JHU_13TeV_py8+VBFToH_Pow_JHU4l_LHE_13TeV+Hadronizer_TuneCP5_13TeV_powhegEmissionVeto_pythia8+HARVESTGEN2

Summary:

No significant changes to the logs found
Reco comparison results: 6 differences found in the comparisons
DQMHistoTests: Total files compared: 40
DQMHistoTests: Total histograms compared: 2751113
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 2751084
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.004 KiB( 39 files compared)
DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
Checked 170 log files, 37 edm output root files, 40 DQM output files
TriggerResults: no differences found

hbakhshi · 2021-10-19T08:00:31Z

It seems that all the tests have passed again. I would appreciate if you could accept this PR, so I can proceed with the sample request. @Saptaparna

hbakhshi · 2021-10-20T13:57:30Z

@SiewYan
Would you please let me know what else should I do for this PR to be approved and merged?

qliphy · 2021-10-25T00:49:14Z

ping @cms-sw/generators-l2

Saptaparna · 2021-10-25T00:56:01Z

+1 @SiewYan any additional comments?

SiewYan · 2021-10-25T01:51:25Z

@Saptaparna , nope, looks all good to me. thanks.

SiewYan · 2021-10-25T01:51:38Z

+1

cmsbuild · 2021-10-25T01:51:51Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2021-10-25T02:41:15Z

@hbakhshi It seems you have not addressed all comments from @Dr15Jones, for example, the suggestions to try LogDebug.

hbakhshi · 2021-10-25T07:53:11Z

Hi @qliphy
Thanks for your comment. Indeed that is the only suggestion I didn't apply. I think this way I can monitor the activity of the filter better. Let me know if there is any strict rule for this

qliphy · 2021-10-25T13:29:29Z

+1

AJJGenJet filter added.

a99b0a9

cmsbuild changed the base branch from CMSSW_12_1_X to master October 5, 2021 23:04

cmsbuild added this to the CMSSW_12_1_X milestone Oct 5, 2021

cmsbuild added code-checks-pending generators-pending orp-pending pending-signatures tests-pending labels Oct 5, 2021

cmsbuild added code-checks-rejected and removed code-checks-pending labels Oct 5, 2021

AJJGenJetFilter format updated

09b7d9e

cmsbuild added code-checks-pending and removed code-checks-rejected labels Oct 5, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 5, 2021

Dr15Jones suggested changes Oct 6, 2021

View reviewed changes

AJJGenJetFilter updated

ec83a8c

cmsbuild added code-checks-pending and removed code-checks-approved labels Oct 6, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 6, 2021

Dr15Jones reviewed Oct 6, 2021

View reviewed changes

parameters converted to 'tracked' and default values are set properly

ff34c1a

cmsbuild removed the code-checks-approved label Oct 6, 2021

cmsbuild added the code-checks-approved label Oct 18, 2021

cmsbuild added tests-started and removed tests-pending labels Oct 18, 2021

cmsbuild added tests-approved and removed tests-started labels Oct 18, 2021

cmsbuild added fully-signed generators-approved and removed generators-pending pending-signatures labels Oct 25, 2021

cmsbuild added orp-approved and removed orp-pending labels Oct 25, 2021

cmsbuild merged commit 4b6b4fa into cms-sw:master Oct 25, 2021

cmsbuild mentioned this pull request Oct 26, 2021

DO NOT MERGE: junk pull request for testing profiling scripts. #35834

Closed

hbakhshi added a commit to hbakhshi/cmssw that referenced this pull request Nov 4, 2021

backporting of PR cms-sw#35547

cdf7e44

hbakhshi mentioned this pull request Nov 4, 2021

AJJGenJetFilter to filter photon+2jets events at GenLevel #35981

Merged

This was referenced Oct 18, 2022

Integration of AJJGenJetFilter to CMSSW_10_6_X #39706

Merged

Update AJJGenJetFilter.cc #39788

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

AJJGenJet filter added. #35547

AJJGenJet filter added. #35547

hbakhshi commented Oct 5, 2021

cmsbuild commented Oct 5, 2021

cmsbuild commented Oct 5, 2021

cmsbuild commented Oct 5, 2021

cmsbuild commented Oct 5, 2021

Dr15Jones Oct 6, 2021

cmsbuild commented Oct 6, 2021

cmsbuild commented Oct 6, 2021

Dr15Jones Oct 6, 2021

Dr15Jones Oct 6, 2021

hbakhshi Oct 6, 2021

cmsbuild commented Oct 18, 2021

SiewYan commented Oct 18, 2021

cmsbuild commented Oct 18, 2021

hbakhshi commented Oct 19, 2021

hbakhshi commented Oct 20, 2021

qliphy commented Oct 25, 2021

Saptaparna commented Oct 25, 2021

SiewYan commented Oct 25, 2021

SiewYan commented Oct 25, 2021

cmsbuild commented Oct 25, 2021

qliphy commented Oct 25, 2021

hbakhshi commented Oct 25, 2021

qliphy commented Oct 25, 2021

AJJGenJet filter added. #35547

AJJGenJet filter added. #35547

Conversation

hbakhshi commented Oct 5, 2021

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Oct 5, 2021

cmsbuild commented Oct 5, 2021

cmsbuild commented Oct 5, 2021

cmsbuild commented Oct 5, 2021

Dr15Jones Oct 6, 2021

Choose a reason for hiding this comment

cmsbuild commented Oct 6, 2021

cmsbuild commented Oct 6, 2021

Dr15Jones Oct 6, 2021

Choose a reason for hiding this comment

Dr15Jones Oct 6, 2021

Choose a reason for hiding this comment

hbakhshi Oct 6, 2021

Choose a reason for hiding this comment

cmsbuild commented Oct 18, 2021

SiewYan commented Oct 18, 2021

cmsbuild commented Oct 18, 2021

Comparison Summary

hbakhshi commented Oct 19, 2021

hbakhshi commented Oct 20, 2021

qliphy commented Oct 25, 2021

Saptaparna commented Oct 25, 2021

SiewYan commented Oct 25, 2021

SiewYan commented Oct 25, 2021

cmsbuild commented Oct 25, 2021

qliphy commented Oct 25, 2021

hbakhshi commented Oct 25, 2021

qliphy commented Oct 25, 2021