-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HLT_PixelClusters to DQM BeamSpot clients #35843
Add HLT_PixelClusters to DQM BeamSpot clients #35843
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35843/26208
|
A new Pull Request was created by @francescobrivio for master. It involves the following packages:
@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
-1 Failed Tests: UnitTests Unit TestsI found errors in the following unit tests: ---> test TestDQMOnlineClient-sistrip_dqm_sourceclient had ERRORS Comparison SummarySummary:
|
please test with #35826 |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e2c9fa/19946/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Since it was decided in https://its.cern.ch/jira/browse/CMSHLT-2174 to add the new HLT_PixelClusters_WP1_ZeroBias
path to the BeamSpot-related streams (
Express
,ExpressAlignment
andDQMOnlineBeamSpot
) this PR updates the DQM BeamSpot clients to pick up events from these new paths.(In the future this could be controlled through the TriggerBits tag in the GT, but for now it's still hard-coded)
PR validation:
Code compiles.
The backport to 12_0_X must be tested in P5 online machines.
Backport:
A backport to 12_0_X is provided in #35844
FYI @gennai @mmusich @dzuolo @mzarucki