-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the CUDA/SoA pixel clusterizer use the same thresholds as the legacy module #35570
Make the CUDA/SoA pixel clusterizer use the same thresholds as the legacy module #35570
Conversation
enable gpu |
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35570/25811
|
A new Pull Request was created by @fwyzard (Andrea Bocci) for master. It involves the following packages:
@Martin-Grunewald, @missirol can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c4bd5f/19463/summary.html GPU Comparison SummarySummary:
Comparison SummarySummary:
|
+hlt
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Make the CUDA/SoA pixel clusterizer use the same thresholds as the legacy module.
This allows for changes like those in #35518 to be picked up transparently by the CUDA/SoA modules.
PR validation:
Checked that modifications to the parameters in the legacy modukes propagate to the CUDA/SoA modules.