Add a workaround for AlCa paths to the Patatrack customisation

[fwyzard]

PR description:

The AlCa LumiPixelsCounts paths use the pixel cluster modules directly, without any Sequence or Task.
After applying the Patatrack customisation, this leaves those modules both "scheduled" (on the AlCa paths) and "unscheduled" (on every other path), breaking the latter.

To work around this issue, the Patatrack customisation now redefines the AlCa LumiPixelsCounts using the HLTDoLocalPixelSequence and the HLTDoLocalPixelTask, making the pixel modules unscheduled.

PR validation:

Applying the Patatrack customisation to the latest HLT menu and running over 2018 data now works.

[fwyzard]

enable gpu

[fwyzard]

please test

[fwyzard]

type bug-fix

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35566/25809

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

• HLTrigger/Configuration (hlt)

@Martin-Grunewald, @missirol can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @silviodonato this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[perrotta]

"v1" because newer versions are / will be already fixed: correct?

[fwyzard]

hopefully :-)

[Martin-Grunewald]

Well, we have NOt increased version numbers for a long time now...

[Martin-Grunewald]

So I understand this should go into ConfDB as an update to the paths in 12_1?

[Martin-Grunewald]

ie, for both cpu and gpu

[Martin-Grunewald]

and then it should be an overall customisation until then (ie, in customiseHLTforCMSSW)?

[fwyzard]

I assume we are getting close to migrating the whole menu to the Task-enabled ConfDB; when that happens, this change can be applied there directly.
Until then, we can stay at "v1"...

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-034412/19457/summary.html
COMMIT: e9ee084
CMSSW: CMSSW_12_1_X_2021-10-06-2300/slc7_amd64_gcc900
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35566/19457/install.sh to create a dev area with all the needed externals and cmssw changes.

GPU Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 4
• DQMHistoTests: Total histograms compared: 19735
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 19729
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
• Checked 12 log files, 9 edm output root files, 4 DQM output files
• TriggerResults: no differences found

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 40
• DQMHistoTests: Total histograms compared: 3219394
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3219371
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 39 files compared)
• Checked 169 log files, 37 edm output root files, 40 DQM output files
• TriggerResults: no differences found

[missirol]

Hi @fwyzard, this looks okay to me as is.

Just one clarification: in the way you rewrote the paths, the order of some filters is slightly different (for example, in HLT_FULL_cff the filter hltPixelTrackerHVOn is before the prescale filter); I assume this re-ordering won't need to be done in ConfDB?

[fwyzard]

Actually, I think it would make sense to reorder them in ConfDB as well: by having the hltPixelTrackerHVOn after the prescaler, we ensure that this path can use consistent prescales as all other paths seeded by zero bias.

[missirol]

Okay, thanks. Then, I guess I'll need to follow up with the group(s) responsible for the paths, and make this change via JIRA.

[missirol]

+hlt

• workaround for the Patatrack customisation function, to be removed once the HLT configs are centrally moved to Tasks (and modules running scheduled inside paths are avoided)
• noted that the order of filters in AlCa_LumiPixelsCounts_Random_v and AlCa_LumiPixelsCounts_ZeroBias_v should be corrected

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1