-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
introduce auto:phase1_2021_dd4hep
and use it in RelVals
#35464
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35464/25619
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages:
@malbouis, @yuanchao, @jordan-martins, @bbilin, @wajidalikhan, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @francescobrivio, @tvami can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 |
Thanks @mmusich this is a nice suggestion, but I'm not sure this is the way we want to go now (we should have done actually a couple of months ago as it would have been easier to maintain during the validation 😅 ). But if we now manage to switch to DD4hep in 12_1 then we could implement something like in the opposite way, i.e. add a customization to go back to DDD if needed. |
@francescobrivio what's the timeline to do the switch? 12_1_0_pre4 or 12_1_0_pre5 ? |
That's what we are discussing :)
Indeed! thanks a lot for the suggestion, really appreciated! |
good. If it's for pre5 this can go in ~now and you can do the switch-over later. |
assign geometry |
New categories assigned: geometry @Dr15Jones,@cvuosalo,@civanch,@ianna,@mdhildreth,@makortel you have been requested to review this Pull request/Issue and eventually sign? Thanks |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-724263/19221/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Comparison SummarySummary:
|
The plan is to test DD4Hep on top of pre4 and switch to it for pre5. |
@civanch but this is only true fo Run-3 MCs right? Data and Phase-2 will come later, no? What's the ETA for data change? After the 12_1_0 comes out and got validated? |
As I see @tvami signs, I wonder what is the status of this PR? It is PR to merge, or it is a draft as now? |
Hi @srimanob, it used to be a draft because I wanted to collect feedback first. Since AlCa seems to agree, it's now open for review. |
auto:phase1_2021_dd4hep
and use it in RelValsauto:phase1_2021_dd4hep
and use it in RelVals
P.s.: let me know if you wish also a backport |
Thanks @mmusich I don't think we need a backport for this. |
Once more about the plan for 12_1_0_pre4:
In this way, we can validate DDD geometry as the baseline versus previous versions and additionally validate DD4Hep versus DDD. The goal is to switch to DD4Hep in pre5 if the validation will converge. |
+1 |
Does this PR need before another PR? Can we discuss on the plan on Monday Alca meeting before merging? |
@srimanob this PR doesn't need any other PR before. |
@srimanob on the other hand there is a PR planned after this, so please sign it asap, so we can go ahead with the PR that includes the correct DD4HEP tags |
Hi @tvami What I would like to clarify is that if we switch to DD4hep in pre5, what is the migration plan? For example, how will we treat GT in near future, i.e. 12_2 with dd4hep tag as default in GT? This PR can be merged if you would like, I am OK to sign, but then it will be another piece to change in future. If this come earlier during the update on dd4hep, I will not be slow on signing it. This is why I would like to discuss the future of this feature. I assume for GT on pre4, you can have real GT for DD4hep. |
@srimanob If dd4hep becomes default, all the physical GlobalTags in autoCond will have to be changed and this modifier will do nothing (e.g. will reapply changes that are already there).
why? This can be used as "optional GT for Run-3 with DD4Hep" for the pre4 relvals. |
yes, @srimanob the plan is what Marco wrote. We will rename the modifier in this PR so that it takes the DDD geom after the DD4HEP becomes the default (as so will be in the default GTs) Again as Marco said, we do not plan to have a dedicated GT for the pre4 relvals, we plan to have the correct DD4HEP tags in the follow-up of this PR and then use |
Please note that this is actually a less error prone approach as well, this way the differences between the DD4HEP GT and the standard GT will really just be the geometry tags, and other changes will be factored out (like what happened in the past with HCAL response and ECAL PF thresholds) And since we wanted to have the changes in two steps, merging this is urgent, so the new PR can include the tags that are indeed should be included in the pre4 release on Tuesday |
+upgrade This PR introduces the way to make dd4hep GT on-the-fly from |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1
|
PR description:
Implement proposal described in #35436 (comment) by creating a symbolic GlobalTag assembled on-the-fly (
auto:phase1_2021_dd4hep
) and putting it on par with the currentauto:phase1_2021_realistic
excepted the dd4hep geometry tags.This guarantees the new key will stay up-to-date with the main 2021 realistic GT in automatic way.
PR validation:
Run successfully
runTheMatrix.py -l 11634.912 -t 4 -j 8
.NB: Changes are expected since the current diff between the main 2021 Global Tag and the one used in RelVals is:
and these two differences:
are re-absorbed here.
if this PR is a backport please specify the original PR and why you need to backport that PR:
N/A
cc:
@cvuosalo