PPS: misaligned geometry built only optionally, off by default

[jan-kaspar]

PR description:

This PR adds a flag to CTPPSGeometryESModule whether the "misaligned" geometry shall be built. The flag is set to false by default. The motivation for this change includes:

• the "misaligned" geometry is only used in special alignment studies,
• the "misaligned" geometry causes problems in PPS HLT workflows (in progress), probably due to missing conditions data in the DB.

This PR is expected to be fully backward compatible, with no impact on the results from standard workflows. The (mis)alignment studies have so far been performed with the "direct" simulation of PPS, which uses CTPPSCompositeESSource instead of CTPPSGeometryESModule. The direct simulation is thus not affected by this PR.

No backports are foreseen.

PR validation:

The plots below compare histograms produced before this PR (blue) and with this PR (red dashed):

• direct simulation WFs: dirsim_cmp.pdf -- no difference as expected.
• Run2 reconstruction WFs: reco_cmp.pdf -- no difference as expected.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35423/25547

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @jan-kaspar for master.

It involves the following packages:

• Geometry/VeryForwardGeometryBuilder (geometry)

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@bsunanda, @fabferro, @fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[civanch]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bafe2d/19170/summary.html
COMMIT: 26c4541
CMSSW: CMSSW_12_1_X_2021-09-27-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35423/19170/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 40
• DQMHistoTests: Total histograms compared: 3211080
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3211058
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 39 files compared)
• Checked 169 log files, 37 edm output root files, 40 DQM output files
• TriggerResults: no differences found

[cvuosalo]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1