Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protection against missing discriminators for offline taus in L1 DQM #35305

Merged
merged 2 commits into from
Sep 17, 2021
Merged

Protection against missing discriminators for offline taus in L1 DQM #35305

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4cb5eeb
Protection against missing discriminators for offline taus in L1 DQM
lathomas Sep 16, 2021
d9cf860
Fixing LogWarning message
lathomas Sep 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions DQMOffline/L1Trigger/src/L1TTauOffline.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -704,6 +704,19 @@ void L1TTauOffline::getProbeTaus(const edm::Event& iEvent,
TLorentzVector mytau;
mytau.SetPtEtaPhiE(tauIt->pt(), tauIt->eta(), tauIt->phi(), tauIt->energy());

if ((*antimu)[tauCandidate].workingPoints.empty()) {
LogWarning("This offline tau has no antimu discriminator, skipping");
Copy link
Contributor

@tvami tvami Sep 16, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lathomas isnt the structure with the LogWarning something like
edm::LogWarning("category") << "message to be printed";

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I think this should be
edm::LogWarning("L1TTauOffline") << "This offline tau has no antimu discriminator, skipping";
Please do the same with the other ones too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, will do.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lathomas please dont forget to push your fix :)

continue;
}
if ((*antiele)[tauCandidate].workingPoints.empty()) {
LogWarning("This offline tau has no antiele discriminator, skipping");
continue;
}
if ((*comb3T)[tauCandidate].workingPoints.empty()) {
LogWarning("This offline tau has no comb3T discriminator, skipping");
continue;
}

if (fabs(tauIt->charge()) == 1 && fabs(tauIt->eta()) < 2.1 && tauIt->pt() > 20 &&
(*antimu)[tauCandidate].workingPoints[AntiMuWPIndex_] &&
(*antiele)[tauCandidate].workingPoints[AntiEleWPIndex_] && (*dmf)[tauCandidate] > 0.5 &&
Expand Down