Protection against missing discriminators for offline taus in L1 DQM #35305
Conversation
|
type bug-fix |
|
urgent |
| @@ -704,6 +704,19 @@ void L1TTauOffline::getProbeTaus(const edm::Event& iEvent, | |||
| TLorentzVector mytau; | |||
| mytau.SetPtEtaPhiE(tauIt->pt(), tauIt->eta(), tauIt->phi(), tauIt->energy()); | |||
|
|
|||
| if ((*antimu)[tauCandidate].workingPoints.empty()) { | |||
| LogWarning("This offline tau has no antimu discriminator, skipping"); | |||
There was a problem hiding this comment.
@lathomas isnt the structure with the LogWarning something like
edm::LogWarning("category") << "message to be printed";
There was a problem hiding this comment.
Yes I think this should be
edm::LogWarning("L1TTauOffline") << "This offline tau has no antimu discriminator, skipping";
Please do the same with the other ones too
There was a problem hiding this comment.
Hi @lathomas please dont forget to push your fix :)
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35305/25320
|
|
A new Pull Request was created by @lathomas for master. It involves the following packages:
@emanueleusai, @ahmad3213, @cmsbuild, @rekovic, @jfernan2, @pmandrik, @cecilecaillol, @pbo0, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild , please test |
cmsbuild
added
code-checks-pending
tests-pending
and removed
tests-started
code-checks-approved
labels
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35305/25331
|
|
Pull request #35305 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @rekovic, @jfernan2, @pmandrik, @cecilecaillol, @pbo0, @rvenditti can you please check and sign again. |
|
@cmsbuild , please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ccde59/18676/summary.html Comparison SummarySummary:
|
|
+1 |
|
+1 |
|
merge |
|
@tvami I won't be able to take care of the backport(s). Can we identify someone else? |
PR description:
This (hopefully) is a short term bug fix of the issue described in #35304
In very rare cases, the anti electron discriminators seem to be missing for offline tau, leading to a crash in the L1 DQM code.
A protection is added to skip such offline taus.
PR validation:
Checked that the crash in #35304 is gone after this fix.
@tvami