Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run3-gex93A Modify the run3 scenarios with the modified material xml files #35290

Merged
merged 1 commit into from
Sep 17, 2021

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented Sep 15, 2021

PR description:

Modify the run3 scenarios with the modified material xml files. D86 scenario of phase2 is also affected because of changes in the material file used for the tracker cable going through the gap between EB/HB and HGCal

PR validation:

Use the runTheMatrix test workflows

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35290/25301

  • This PR adds an extra 44KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

  • Configuration/Geometry (geometry, upgrade)
  • Geometry/CMSCommonData (geometry, upgrade)
  • Geometry/TrackerCommonData (geometry)

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please review it and eventually sign? Thanks.
@vargasa, @JanFSchulte, @kpedro88, @VinInn, @Martin-Grunewald, @mmusich, @ghugo83, @mtosi, @fabiocos, @slomeo, @venturia this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f7b975/18637/summary.html
COMMIT: a565857
CMSSW: CMSSW_12_1_X_2021-09-14-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35290/18637/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f7b975/18637/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f7b975/18637/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3167 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 3000833
  • DQMHistoTests: Total failures: 6353
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2994458
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: found differences in 1 / 38 workflows

@cvuosalo
Copy link
Contributor

@bsunanda Do you think it is expected that these small material changes would be enough to create comparison differences in the DD4hep workflow 11634.911?

@cvuosalo
Copy link
Contributor

@bsunanda Will the reduced material scenarios also require these changes?

@cvuosalo
Copy link
Contributor

+1

@bsunanda
Copy link
Contributor Author

@cvuosalo Yes in view of the changes in dd4hep case it may be worthwhile to modify the changed scenarios. We need to relook at the legacy scenario as well. But the priority is Run3 default geometry

@civanch
Copy link
Contributor

civanch commented Sep 16, 2021

urgent

@srimanob
Copy link
Contributor

If I read the PR correctly, the change of 2021 is only on tracker. Why do we see a lot of effects in most of subsystems?
https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_12_1_X_2021-09-14-1100+f7b975/45481/11634.911_TTbar_14TeV+2021_DD4hep+TTbar_14TeV_TuneCP5_GenSim+Digi+Reco+HARVEST+ALCA/

Is it because of many PRs are merged on top of IB?

@civanch
Copy link
Contributor

civanch commented Sep 16, 2021

@srimanob , if a tiny modification is introduced to tracker geometry or material, then tracking history for all CMS should be changed.

@srimanob
Copy link
Contributor

+Upgrade

This PR introduces a change in tracker material as what PR title says. However, I would prefer that the title and PR description are updated to reflect what include in this PR because there is a change also in Phase-2 ECAL XML.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Sep 16, 2021

@bsunanda Would you follow suggestions above from @srimanob ?

@qliphy
Copy link
Contributor

qliphy commented Sep 17, 2021

+Upgrade

This PR introduces a change in tracker material as what PR title says. However, I would prefer that the title and PR description are updated to reflect what include in this PR because there is a change also in Phase-2 ECAL XML.

@bsunanda Please see above.

@bsunanda
Copy link
Contributor Author

Yes, I know that. It only affects D86 scenario for phase2 which is currently under investigation. So this will not affect any of the validated phase2 scenarios

@bsunanda
Copy link
Contributor Author

@qliphy @perrotta @cvuosalo @civanch @srimanob Please merge this PR

@qliphy
Copy link
Contributor

qliphy commented Sep 17, 2021

+1

@qliphy
Copy link
Contributor

qliphy commented Sep 17, 2021

merge

@cmsbuild cmsbuild merged commit fad898f into cms-sw:master Sep 17, 2021
cmsbuild added a commit that referenced this pull request Sep 24, 2021
Run3-gex93B Modify Run3 and Phase2D86 geometry due to change in some material xml files (Backport #35290)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants