-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run3-gex93A Modify the run3 scenarios with the modified material xml files #35290
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35290/25301
|
A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master. It involves the following packages:
@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild Please test |
@bsunanda Do you think it is expected that these small material changes would be enough to create comparison differences in the DD4hep workflow 11634.911? |
@bsunanda Will the reduced material scenarios also require these changes? |
+1 |
@cvuosalo Yes in view of the changes in dd4hep case it may be worthwhile to modify the changed scenarios. We need to relook at the legacy scenario as well. But the priority is Run3 default geometry |
urgent |
If I read the PR correctly, the change of 2021 is only on tracker. Why do we see a lot of effects in most of subsystems? Is it because of many PRs are merged on top of IB? |
@srimanob , if a tiny modification is introduced to tracker geometry or material, then tracking history for all CMS should be changed. |
+Upgrade This PR introduces a change in tracker material as what PR title says. However, I would prefer that the title and PR description are updated to reflect what include in this PR because there is a change also in Phase-2 ECAL XML. |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
@bsunanda Please see above. |
Yes, I know that. It only affects D86 scenario for phase2 which is currently under investigation. So this will not affect any of the validated phase2 scenarios |
+1 |
merge |
Run3-gex93B Modify Run3 and Phase2D86 geometry due to change in some material xml files (Backport #35290)
PR description:
Modify the run3 scenarios with the modified material xml files. D86 scenario of phase2 is also affected because of changes in the material file used for the tracker cable going through the gap between EB/HB and HGCal
PR validation:
Use the runTheMatrix test workflows
if this PR is a backport please specify the original PR and why you need to backport that PR:
Nothing special