Remove unused headers for RECO & SIM packages

[yuanchao]

PR description:

Remove unused headers in RECO & SIM packages.

Following the issue #31505, the following headers are unused in several package:

• RecoEgamma/EgammaTools/interface/ConversionTools.h
• RecoEgamma/EgammaTools/interface/EffectiveAreas.h
• RecoHI/HiJetAlgos/interface/UECalibration.h
• RecoJets/JetAnalyzers/doc/myJetAna.html
• RecoJets/JetAnalyzers/interface/CaloTowerBoundries.h
• RecoJets/JetAnalyzers/interface/MyCluster.h
• RecoJets/JetAnalyzers/interface/myFilter.h
• RecoJets/JetAnalyzers/interface/myJetAna.h
• RecoJets/JetAnalyzers/test/myFilter.cc
• RecoJets/JetAnalyzers/test/myJetAna.cc
• RecoLocalCalo/EcalRecAlgos/interface/EcalUncalibRecHitLeadingEdgeAlgo.h
• RecoMuon/TrackingTools/interface/MuonSeedDetLayer.h
• RecoTracker/SpecialSeedGenerators/interface/EtaPhiMeasurementEstimator.h
• RecoTracker/TkMSParametrization/interface/rangesIntersect.h
• RecoTracker/TrackProducer/interface/GsfTrackProducerAlgorithm.h
• RecoTracker/TransientTrackingRecHit/interface/GSTransientTrackingRecHit.h
• RecoVertex/ConfigurableVertexReco/interface/ReconstructorFromLinPtFinder.h
• RecoVertex/KinematicFit/interface/CombinedKinematicConstraintT.h
• RecoVertex/LinearizationPointFinders/interface/MonteCarloLinearizationPointFinder.h
• RecoVertex/LinearizationPointFinders/src/MonteCarloLinearizationPointFinder.cc
• SimCalorimetry/CaloSimAlgos/interface/CaloVNoisifier.h
• SimDataFormats/RPCDigiSimLink/interface/RPCDigiSimLinkfwd.h
• SimDataFormats/TrackerDigiSimLink/interface/PixelDigiSimLinkfwd.h
• SimDataFormats/TrackerDigiSimLink/interface/StripCompactDigiSimLinksfwd.h
• SimDataFormats/TrackerDigiSimLink/interface/StripDigiSimLinkfwd.h
• SimG4CMS/Calo/interface/HcalTestHistoClass.h
• SimG4Core/Application/interface/DDDWorldObserver.h
• SimG4Core/Notification/interface/ComponentBuilder.h
• SimG4Core/Notification/interface/ComponentFactoryByName.h
• SimG4Core/Notification/interface/DispatchableG4Step.h
• SimG4Core/Notification/interface/OwnIt.h

PR validation:

Code compiles. Run local limited runTheMatrix.py tests.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Not a backport and no backport forseen.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35167/25095

• This PR adds an extra 36KB to repository

[cmsbuild]

A new Pull Request was created by @yuanchao (Yuan CHAO) for master.

It involves the following packages:

• RecoEgamma/EgammaTools (reconstruction)
• RecoHI/HiJetAlgos (reconstruction)
• RecoJets/JetAnalyzers (reconstruction)
• RecoLocalCalo/EcalRecAlgos (reconstruction)
• RecoMuon/TrackingTools (reconstruction)
• RecoTracker/SpecialSeedGenerators (reconstruction)
• RecoTracker/TkMSParametrization (reconstruction)
• RecoTracker/TrackProducer (reconstruction)
• RecoTracker/TransientTrackingRecHit (reconstruction)
• RecoVertex/ConfigurableVertexReco (reconstruction)
• RecoVertex/KinematicFit (reconstruction)
• RecoVertex/LinearizationPointFinders (reconstruction)
• SimCalorimetry/CaloSimAlgos (simulation)
• SimDataFormats/RPCDigiSimLink (simulation)
• SimDataFormats/TrackerDigiSimLink (simulation)
• SimG4CMS/Calo (simulation)
• SimG4Core/Application (simulation)
• SimG4Core/Notification (simulation)

@jpata, @cmsbuild, @civanch, @mdhildreth, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @yslai, @felicepantaleo, @jainshilpi, @abbiendi, @argiro, @bsunanda, @Fedespring, @thomreis, @ahinzmann, @lgray, @mmusich, @seemasharmafnal, @slomeo, @jdolen, @makortel, @JanFSchulte, @jhgoh, @dgulhan, @apsallid, @yenjie, @cericeci, @simonepigazzini, @trocino, @rociovilar, @sscruz, @Sam-Harper, @cvuosalo, @afiqaize, @GiacomoSguazzoni, @rovere, @VinInn, @jdamgov, @bellan, @nhanvtran, @gkasieczka, @schoef, @ebrondol, @mtosi, @fabiocos, @clelange, @HuguesBrun, @rchatter, @mandrenguyen, @varuns23, @jazzitup, @calderona, @sobhatta, @lecriste, @kurtejung, @gpetruc, @mariadalfonso, @yetkinyilmaz, @ram1123 this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[yuanchao]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e76ad5/18337/summary.html
COMMIT: 276099b
CMSSW: CMSSW_12_1_X_2021-09-05-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35167/18337/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 3001001
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3000979
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[civanch]

+1

[slava77]

The following do not follow a pattern of unused header removal and also remove the code using the headers:

• RecoJets/JetAnalyzers/doc/myJetAna.html
• RecoJets/JetAnalyzers/interface/myFilter.h RecoJets/JetAnalyzers/test/myFilter.cc
• RecoJets/JetAnalyzers/interface/myJetAna.h RecoJets/JetAnalyzers/test/myJetAna.cc

@camclean @alefisico
@cms-sw/hcal-dpg-l2 it seems like this may have been used by HCAL DPG not so long ago (unless I mis-attributed Frank's commit a068b01). Please check/confirm that this is not used anymore

[slava77]

RecoLocalCalo/EcalRecAlgos/interface/EcalUncalibRecHitLeadingEdgeAlgo.h
was used in EcalUncalibRecHitWorkerGlobal until #8717 (2015)
@cms-sw/ecal-dpg-l2 please clarify if EcalUncalibRecHitLeadingEdgeAlgo is still needed and should be kept in the release.
Thank you.

[slava77]

RecoVertex/KinematicFit/interface/CombinedKinematicConstraintT.h was used/tested in RecoVertex/KinematicFit/test/test_CombinedConstraint.cpp which was apparently lost during CVS -> git import (I did not find any indications that it was removed intentionally).

So, perhaps it's practical to eventually recover the /test directory as of https://github.com/cms-sw/cmssw/tree/0a6192c876dbfe83249fbaba871c68ac029fcae2/RecoVertex/KinematicFit/test

@VinInn (primary developer since fbcb3b8)
@emilbols @mmusich @vmariani
please check and comment for BTV/TRK or perhaps other use cases as in BPH.
Thank you.

[mseidel42]

@cms-sw/hcal-dpg-l2 it seems like this may have been used by HCAL DPG not so long ago (unless I mis-attributed Frank's commit a068b01). Please check/confirm that this is not used anymore

That was almost 10 years ago, I don't think it is used anymore!

[slava77]

@cms-sw/hcal-dpg-l2 it seems like this may have been used by HCAL DPG not so long ago (unless I mis-attributed Frank's commit a068b01). Please check/confirm that this is not used anymore

That was almost 10 years ago, I don't think it is used anymore!

OK, thanks for checking.

[slava77]

So, for reco the following remain candidates to keep

• RecoLocalCalo/EcalRecAlgos/interface/EcalUncalibRecHitLeadingEdgeAlgo.h
  • waiting for feedback in Remove unused headers for RECO & SIM packages #35167 (comment)
• RecoVertex/KinematicFit/interface/CombinedKinematicConstraintT.h
  • waiting for feedback in Remove unused headers for RECO & SIM packages #35167 (comment)

[emilbols]

RecoVertex/KinematicFit/interface/CombinedKinematicConstraintT.h was used/tested in RecoVertex/KinematicFit/test/test_CombinedConstraint.cpp which was apparently lost during CVS -> git import (I did not find any indications that it was removed intentionally).

So, perhaps it's practical to eventually recover the /test directory as of https://github.com/cms-sw/cmssw/tree/0a6192c876dbfe83249fbaba871c68ac029fcae2/RecoVertex/KinematicFit/test

I dont think this is being used by anyone active in btv. I think for the most part this code is forgotten from a btv standpoint.

[thomreis]

From ECAL DPG point of view RecoLocalCalo/EcalRecAlgos/interface/EcalUncalibRecHitLeadingEdgeAlgo.h is not needed anymore and can be removed.

[slava77]

+reconstruction

for #35167 276099b

• code changes are in line with the PR description and the few questionable removals were confirmed to be OK
• jenkins tests pass

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1