-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add 11634.7 wf for 2021 ttbar mkFit to the short matrix #35235
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35235/25198
|
@cmsbuild please test |
A new Pull Request was created by @slava77 (Slava Krutelyov) for master. It involves the following packages:
@jordan-martins, @chayanit, @bbilin, @wajidalikhan, @AdrianoDee, @srimanob, @kskovpen can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
-1 Failed Tests: Build ClangBuild The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: BuildI found compilation error when building: >> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-09-10-1100/src/RecoTracker/MkFit/plugins/MkFitSeedConverter.cc >> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-09-10-1100/src/RecoTracker/MkFit/plugins/MkFitSiPixelHitConverter.cc >> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-09-10-1100/src/RecoTracker/MkFit/plugins/MkFitSiStripHitConverter.cc >> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-09-10-1100/src/RecoTracker/MkFit/plugins/createPhase1TrackerGeometry.cc /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-09-10-1100/src/RecoTracker/MkFit/plugins/createPhase1TrackerGeometry.cc: In function 'void {anonymous}::setupSteeringParamsIter0(mkfit::IterationConfig&)': /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-09-10-1100/src/RecoTracker/MkFit/plugins/createPhase1TrackerGeometry.cc:35:10: error: 'class mkfit::SteeringParams' has no member named 'set_iterator_limits' 35 | sp.set_iterator_limits(2, 0); | ^~~~~~~~~~~~~~~~~~~ /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-09-10-1100/src/RecoTracker/MkFit/plugins/createPhase1TrackerGeometry.cc:50:10: error: 'class mkfit::SteeringParams' has no member named 'set_iterator_limits' 50 | sp.set_iterator_limits(2, 0); | ^~~~~~~~~~~~~~~~~~~ Clang BuildI found compilation error while trying to compile with clang. Command used:
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-09-10-1100/src/RecoTracker/MkFit/plugins/MkFitProducer.cc >> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-09-10-1100/src/RecoTracker/MkFit/plugins/MkFitSeedConverter.cc >> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-09-10-1100/src/RecoTracker/MkFit/plugins/MkFitSiPixelHitConverter.cc >> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-09-10-1100/src/RecoTracker/MkFit/plugins/MkFitSiStripHitConverter.cc >> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-09-10-1100/src/RecoTracker/MkFit/plugins/createPhase1TrackerGeometry.cc /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-09-10-1100/src/RecoTracker/MkFit/plugins/createPhase1TrackerGeometry.cc:35:10: error: no member named 'set_iterator_limits' in 'mkfit::SteeringParams' sp.set_iterator_limits(2, 0); ~~ ^ /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-09-10-1100/src/RecoTracker/MkFit/plugins/createPhase1TrackerGeometry.cc:50:10: error: no member named 'set_iterator_limits' in 'mkfit::SteeringParams' sp.set_iterator_limits(2, 0); ~~ ^ |
need to re-test after CMSSW_12_1_X_2021-09-10-2300 is out |
@cmsbuild please test CMSSW_12_1_X_2021-09-11-1100 showed up around 17:30 |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1dc5ef/18521/summary.html Comparison SummarySummary:
|
+Upgrade This is to add new wfs to the short matrix, for PR test. |
@cms-sw/pdmv-l2 |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
in view of enabling mkFit in tracking some time soon, addition of this workflow to the short matrix should allow to regularly monitor that the workflow is working and the changes in outputs are checked in comparisons.