-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removed boost lexical_cast dependency #35211
removed boost lexical_cast dependency #35211
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35211/25159
|
A new Pull Request was created by @Purva-Chaudhari for master. It involves the following packages:
@Dr15Jones, @makortel, @cmsbuild, @alja, @slava77, @jpata can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
+1 |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f7bc38/18458/summary.html Comparison SummarySummary:
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Remove boost lexical cast dependency in MagneticField and Fireworks with corresponding stl alternatives.
PR validation:
compiled and passed runtests
if this PR is a backport:
@davidlange6 @vgvassilev