[GCC11] Fix warning: loop variable binds to a temporary

[iarspider]

PR description:

Log file: https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc7_amd64_gcc11/CMSSW_12_1_X_2021-08-11-1100/PhysicsTools/PatAlgos

/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/014281f7054fa0c78acaef7d47194c17/opt/cmssw/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-08-11-1100/src/PhysicsTools/PatAlgos/plugins/PATObjectUserDataEmbedder.cc: In instantiation of 'static void pat::PATObjectUserDataEmbedder<T>::fillDescriptions(edm::ConfigurationDescriptions&) [with T = pat::Electron]':
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/014281f7054fa0c78acaef7d47194c17/opt/cmssw/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-08-11-1100/src/FWCore/Framework/src/WorkerMaker.h:72:24:   required from 'void edm::WorkerMaker<T>::fillDescriptions(edm::ConfigurationDescriptions&) const [with T = pat::PATObjectUserDataEmbedder<pat::Electron>]'
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/014281f7054fa0c78acaef7d47194c17/opt/cmssw/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-08-11-1100/src/FWCore/Framework/src/WorkerMaker.h:71:8:   required from here
  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/014281f7054fa0c78acaef7d47194c17/opt/cmssw/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-08-11-1100/src/PhysicsTools/PatAlgos/plugins/PATObjectUserDataEmbedder.cc:78:31: warning: loop variable 'what' of type 'const string&' {aka 'const std::__cxx11::basic_string<char>&'} binds to a temporary constructed from type 'const char* const' [-Wrange-loop-construct]
    78 |       for (const std::string &what : {"userFloats", "userInts", "userIntFromBools", "userCands"}) {
      |

PR validation:

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34852/24644

• This PR adds an extra 16KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34852/24644/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34852/24644/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34852/24645

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @iarspider for master.

It involves the following packages:

• PhysicsTools/PatAlgos (reconstruction)

@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@mmarionncern, @gouskos, @JyothsnaKomaragiri, @ahinzmann, @schoef, @rappoccio, @swozniewski, @jdamgov, @jdolen, @nhanvtran, @gkasieczka, @clelange, @emilbols, @hatakeyamak, @mbluj, @gpetruc, @andrzejnovak, @mariadalfonso, @seemasharmafnal this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cf564f/17734/summary.html
COMMIT: e0e933a
CMSSW: CMSSW_12_1_X_2021-08-12-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34852/17734/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @cms-tau-pog Enable boosted tau reco to run at miniAOD #34576
• @iarspider [GCC11] Fix "this pointer is null" in class FWRecoGeometryESProducer of Fireworks/Geometry #34824
• @AdrianoDee Adding LUT approach for PackedCandidates #34446

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cf564f/17734/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cf564f/17734/git-merge-result

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 7 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 2999420
• DQMHistoTests: Total failures: 13
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2999385
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[slava77]

+reconstruction

for #34852 e0e933a

• code changes are in line with the PR description (it seems that the original is still OK since the value/ref matters only inside the loop, but the update is fine)
• jenkins tests pass

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1