Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GCC11] Fix "this pointer is null" in class FWRecoGeometryESProducer of Fireworks/Geometry #34824

Merged
merged 2 commits into from
Aug 12, 2021

Conversation

iarspider
Copy link
Contributor

Error log: https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc7_amd64_gcc11/CMSSW_12_1_X_2021-08-09-1100/Fireworks/Geometry
Error message:

/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/ada76bbef987ba1823d9aebd3a0b2f87/opt/cmssw/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-08-09-1100/src/Fireworks/Geometry/src/FWRecoGeometryESProducer.cc: In member function 'void FWRecoGeometryESProducer::addTIBGeometry(FWRecoGeometry&)':
  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/ada76bbef987ba1823d9aebd3a0b2f87/opt/cmssw/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-08-09-1100/src/Fireworks/Geometry/src/FWRecoGeometryESProducer.cc:79:63: error: 'this' pointer is null [-Werror=nonnull]
    79 |       fwRecoGeometry.idToName[rawid].topology[3] = topo->pitch();                                          \
      |                                                    ~~~~~~~~~~~^~
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/ada76bbef987ba1823d9aebd3a0b2f87/opt/cmssw/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-08-09-1100/src/Fireworks/Geometry/src/FWRecoGeometryESProducer.cc:420:7: note: in expansion of macro 'ADD_SISTRIP_TOPOLOGY'
  420 |       ADD_SISTRIP_TOPOLOGY(current, m_trackerGeom->idToDet(detid));
      |       ^~~~~~~~~~~~~~~~~~~~
  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/ada76bbef987ba1823d9aebd3a0b2f87/opt/cmssw/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-08-09-1100/src/Fireworks/Geometry/src/FWRecoGeometryESProducer.cc:82:63: error: 'this' pointer is null [-Werror=nonnull]
    82 |       fwRecoGeometry.idToName[rawid].topology[3] = topo->pitch();                                          \
      |                                                    ~~~~~~~~~~~^~
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/ada76bbef987ba1823d9aebd3a0b2f87/opt/cmssw/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-08-09-1100/src/Fireworks/Geometry/src/FWRecoGeometryESProducer.cc:420:7: note: in expansion of macro 'ADD_SISTRIP_TOPOLOGY'
  420 |       ADD_SISTRIP_TOPOLOGY(current, m_trackerGeom->idToDet(detid));
      |       ^~~~~~~~~~~~~~~~~~~~
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/ada76bbef987ba1823d9aebd3a0b2f87/opt/cmssw/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-08-09-1100/src/Fireworks/Geometry/src/FWRecoGeometryESProducer.cc: In member function 'void FWRecoGeometryESProducer::addTOBGeometry(FWRecoGeometry&)':
  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/ada76bbef987ba1823d9aebd3a0b2f87/opt/cmssw/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-08-09-1100/src/Fireworks/Geometry/src/FWRecoGeometryESProducer.cc:79:63: error: 'this' pointer is null [-Werror=nonnull]
    79 |       fwRecoGeometry.idToName[rawid].topology[3] = topo->pitch();                                          \
      |                                                    ~~~~~~~~~~~^~
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/ada76bbef987ba1823d9aebd3a0b2f87/opt/cmssw/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-08-09-1100/src/Fireworks/Geometry/src/FWRecoGeometryESProducer.cc:438:7: note: in expansion of macro 'ADD_SISTRIP_TOPOLOGY'
  438 |       ADD_SISTRIP_TOPOLOGY(current, m_trackerGeom->idToDet(detid));
      |       ^~~~~~~~~~~~~~~~~~~~
  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/ada76bbef987ba1823d9aebd3a0b2f87/opt/cmssw/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-08-09-1100/src/Fireworks/Geometry/src/FWRecoGeometryESProducer.cc:82:63: error: 'this' pointer is null [-Werror=nonnull]
    82 |       fwRecoGeometry.idToName[rawid].topology[3] = topo->pitch();                                          \
      |                                                    ~~~~~~~~~~~^~
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/ada76bbef987ba1823d9aebd3a0b2f87/opt/cmssw/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-08-09-1100/src/Fireworks/Geometry/src/FWRecoGeometryESProducer.cc:438:7: note: in expansion of macro 'ADD_SISTRIP_TOPOLOGY'
  438 |       ADD_SISTRIP_TOPOLOGY(current, m_trackerGeom->idToDet(detid));
      |       ^~~~~~~~~~~~~~~~~~~~
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/ada76bbef987ba1823d9aebd3a0b2f87/opt/cmssw/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-08-09-1100/src/Fireworks/Geometry/src/FWRecoGeometryESProducer.cc: In member function 'void FWRecoGeometryESProducer::addTIDGeometry(FWRecoGeometry&)':
  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/ada76bbef987ba1823d9aebd3a0b2f87/opt/cmssw/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-08-09-1100/src/Fireworks/Geometry/src/FWRecoGeometryESProducer.cc:79:63: error: 'this' pointer is null [-Werror=nonnull]
    79 |       fwRecoGeometry.idToName[rawid].topology[3] = topo->pitch();                                          \
      |                                                    ~~~~~~~~~~~^~
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/ada76bbef987ba1823d9aebd3a0b2f87/opt/cmssw/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-08-09-1100/src/Fireworks/Geometry/src/FWRecoGeometryESProducer.cc:456:7: note: in expansion of macro 'ADD_SISTRIP_TOPOLOGY'
  456 |       ADD_SISTRIP_TOPOLOGY(current, m_trackerGeom->idToDet(detid));
      |       ^~~~~~~~~~~~~~~~~~~~
  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/ada76bbef987ba1823d9aebd3a0b2f87/opt/cmssw/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-08-09-1100/src/Fireworks/Geometry/src/FWRecoGeometryESProducer.cc:82:63: error: 'this' pointer is null [-Werror=nonnull]
    82 |       fwRecoGeometry.idToName[rawid].topology[3] = topo->pitch();                                          \
      |                                                    ~~~~~~~~~~~^~
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/ada76bbef987ba1823d9aebd3a0b2f87/opt/cmssw/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-08-09-1100/src/Fireworks/Geometry/src/FWRecoGeometryESProducer.cc:456:7: note: in expansion of macro 'ADD_SISTRIP_TOPOLOGY'
  456 |       ADD_SISTRIP_TOPOLOGY(current, m_trackerGeom->idToDet(detid));
      |       ^~~~~~~~~~~~~~~~~~~~
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/ada76bbef987ba1823d9aebd3a0b2f87/opt/cmssw/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-08-09-1100/src/Fireworks/Geometry/src/FWRecoGeometryESProducer.cc: In member function 'void FWRecoGeometryESProducer::addTECGeometry(FWRecoGeometry&)':
  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/ada76bbef987ba1823d9aebd3a0b2f87/opt/cmssw/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-08-09-1100/src/Fireworks/Geometry/src/FWRecoGeometryESProducer.cc:79:63: error: 'this' pointer is null [-Werror=nonnull]
    79 |       fwRecoGeometry.idToName[rawid].topology[3] = topo->pitch();                                          \
      |                                                    ~~~~~~~~~~~^~
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/ada76bbef987ba1823d9aebd3a0b2f87/opt/cmssw/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-08-09-1100/src/Fireworks/Geometry/src/FWRecoGeometryESProducer.cc:474:7: note: in expansion of macro 'ADD_SISTRIP_TOPOLOGY'
  474 |       ADD_SISTRIP_TOPOLOGY(current, m_trackerGeom->idToDet(detid));
      |       ^~~~~~~~~~~~~~~~~~~~
  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/ada76bbef987ba1823d9aebd3a0b2f87/opt/cmssw/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-08-09-1100/src/Fireworks/Geometry/src/FWRecoGeometryESProducer.cc:82:63: error: 'this' pointer is null [-Werror=nonnull]
    82 |       fwRecoGeometry.idToName[rawid].topology[3] = topo->pitch();                                          \
      |                                                    ~~~~~~~~~~~^~
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/ada76bbef987ba1823d9aebd3a0b2f87/opt/cmssw/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-08-09-1100/src/Fireworks/Geometry/src/FWRecoGeometryESProducer.cc:474:7: note: in expansion of macro 'ADD_SISTRIP_TOPOLOGY'
  474 |       ADD_SISTRIP_TOPOLOGY(current, m_trackerGeom->idToDet(detid));
      |       ^~~~~~~~~~~~~~~~~~~~
cc1plus: some warnings being treated as errors
  gmake: *** [tmp/slc7_amd64_gcc11/src/Fireworks/Geometry/src/FireworksGeometry/FWRecoGeometryESProducer.cc.o] Error 1

PR description:

Added missing assignment of dynamic_cast for RectangularStripTopology and TrapezoidalStripTopology in ADD_SISTRIP_TOPOLOGY macro

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

Before submitting your pull requests, make sure you followed this checklist:

Added missing assignment of `dynamic_cast` for `RectangularStripTopology` and `TrapezoidalStripTopology` in `ADD_SISTRIP_TOPOLOGY` macro
@cmsbuild cmsbuild added this to the CMSSW_12_1_X milestone Aug 10, 2021
@iarspider iarspider changed the title [GCC11] Fix "this pointer is null" [GCC11] Fix "this pointer is null" in class FWRecoGeometryESProducer of Fireworks/Geometry Aug 10, 2021
@iarspider
Copy link
Contributor Author

assign visualization

@iarspider
Copy link
Contributor Author

please test for slc7_amd64_gcc11

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34824/24594

  • This PR adds an extra 16KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34824/24597

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @iarspider for master.

It involves the following packages:

  • Fireworks/Geometry (visualization)

@makortel, @alja, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks.
@alja this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@iarspider
Copy link
Contributor Author

please test for slc7_amd64_gcc11

@alja
Copy link
Contributor

alja commented Aug 10, 2021

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5bc02a/17686/summary.html
COMMIT: 92f2c79
CMSSW: CMSSW_12_1_X_2021-08-09-1100/slc7_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34824/17686/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5bc02a/17686/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5bc02a/17686/git-merge-result

Build

I found compilation error when building:

/cvmfs/cms-ib.cern.ch/nweek-02693/slc7_amd64_gcc11/external/gcc/11.1.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/11.1.1/../../../../x86_64-unknown-linux-gnu/bin/ld: cannot find -lCalibTrackerSiPixelESProducers
/cvmfs/cms-ib.cern.ch/nweek-02693/slc7_amd64_gcc11/external/gcc/11.1.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/11.1.1/../../../../x86_64-unknown-linux-gnu/bin/ld: cannot find -lHeterogeneousCoreCUDACore
/cvmfs/cms-ib.cern.ch/nweek-02693/slc7_amd64_gcc11/external/gcc/11.1.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/11.1.1/../../../../x86_64-unknown-linux-gnu/bin/ld: cannot find -lHeterogeneousCoreCUDAServices
/cvmfs/cms-ib.cern.ch/nweek-02693/slc7_amd64_gcc11/external/gcc/11.1.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/11.1.1/../../../../x86_64-unknown-linux-gnu/bin/ld: cannot find -lCUDADataFormatsCommon
/cvmfs/cms-ib.cern.ch/nweek-02693/slc7_amd64_gcc11/external/gcc/11.1.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/11.1.1/../../../../x86_64-unknown-linux-gnu/bin/ld: cannot find -lHeterogeneousCoreCUDAUtilities
collect2: error: ld returned 1 exit status
gmake: *** [tmp/slc7_amd64_gcc11/src/RecoLocalTracker/SiPixelDigiReProducers/plugins/RecoLocalTrackerSiPixelDigiReProducersPlugins/libRecoLocalTrackerSiPixelDigiReProducersPlugins.so] Error 1
Leaving library rule at src/RecoLocalTracker/SiPixelDigiReProducers/plugins
>> Leaving Package RecoLocalTracker/SiPixelDigiReProducers
>> Package RecoLocalTracker/SiPixelDigiReProducers built
>> Entering Package Utilities/StaticAnalyzers


@smuzaffar
Copy link
Contributor

please test

@smuzaffar
Copy link
Contributor

smuzaffar commented Aug 11, 2021

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5bc02a/17697/summary.html
COMMIT: 92f2c79
CMSSW: CMSSW_12_1_X_2021-08-10-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34824/17697/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

  • 23434.992123434.9921_TTbar_14TeV+2026D49PU_PMXS1S2ProdLike+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+PREMIX_PremixHLBeamSpot14PU+DigiTriggerPU+RecoGlobalPU+MiniAODPU/step2_TTbar_14TeV+2026D49PU_PMXS1S2ProdLike+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+PREMIX_PremixHLBeamSpot14PU+DigiTriggerPU+RecoGlobalPU+MiniAODPU.log
  • 23434.9923434.99_TTbar_14TeV+2026D49PU_PMXS1S2+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+PREMIX_PremixHLBeamSpot14PU+DigiTriggerPU+RecoGlobalPU+HARVESTGlobalPU/step2_TTbar_14TeV+2026D49PU_PMXS1S2+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+PREMIX_PremixHLBeamSpot14PU+DigiTriggerPU+RecoGlobalPU+HARVESTGlobalPU.log
  • 23434.2123434.21_TTbar_14TeV+2026D49PU_ProdLike+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+DigiTriggerPU+RecoGlobalPU+MiniAODPU/step2_TTbar_14TeV+2026D49PU_ProdLike+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+DigiTriggerPU+RecoGlobalPU+MiniAODPU.log
Expand to see more relval errors ...

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 2999420
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2999391
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@qliphy
Copy link
Contributor

qliphy commented Aug 12, 2021

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5bc02a/17715/summary.html
COMMIT: 92f2c79
CMSSW: CMSSW_12_1_X_2021-08-11-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34824/17715/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 2999420
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2999397
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants