-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GCC11] Fix "this pointer is null" in class FWRecoGeometryESProducer of Fireworks/Geometry #34824
Conversation
Added missing assignment of `dynamic_cast` for `RectangularStripTopology` and `TrapezoidalStripTopology` in `ADD_SISTRIP_TOPOLOGY` macro
assign visualization |
please test for slc7_amd64_gcc11 |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34824/24594
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34824/24597
|
A new Pull Request was created by @iarspider for master. It involves the following packages:
@makortel, @alja, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test for slc7_amd64_gcc11 |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
-1 Failed Tests: Build The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: BuildI found compilation error when building: /cvmfs/cms-ib.cern.ch/nweek-02693/slc7_amd64_gcc11/external/gcc/11.1.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/11.1.1/../../../../x86_64-unknown-linux-gnu/bin/ld: cannot find -lCalibTrackerSiPixelESProducers /cvmfs/cms-ib.cern.ch/nweek-02693/slc7_amd64_gcc11/external/gcc/11.1.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/11.1.1/../../../../x86_64-unknown-linux-gnu/bin/ld: cannot find -lHeterogeneousCoreCUDACore /cvmfs/cms-ib.cern.ch/nweek-02693/slc7_amd64_gcc11/external/gcc/11.1.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/11.1.1/../../../../x86_64-unknown-linux-gnu/bin/ld: cannot find -lHeterogeneousCoreCUDAServices /cvmfs/cms-ib.cern.ch/nweek-02693/slc7_amd64_gcc11/external/gcc/11.1.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/11.1.1/../../../../x86_64-unknown-linux-gnu/bin/ld: cannot find -lCUDADataFormatsCommon /cvmfs/cms-ib.cern.ch/nweek-02693/slc7_amd64_gcc11/external/gcc/11.1.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/11.1.1/../../../../x86_64-unknown-linux-gnu/bin/ld: cannot find -lHeterogeneousCoreCUDAUtilities collect2: error: ld returned 1 exit status gmake: *** [tmp/slc7_amd64_gcc11/src/RecoLocalTracker/SiPixelDigiReProducers/plugins/RecoLocalTrackerSiPixelDigiReProducersPlugins/libRecoLocalTrackerSiPixelDigiReProducersPlugins.so] Error 1 Leaving library rule at src/RecoLocalTracker/SiPixelDigiReProducers/plugins >> Leaving Package RecoLocalTracker/SiPixelDigiReProducers >> Package RecoLocalTracker/SiPixelDigiReProducers built >> Entering Package Utilities/StaticAnalyzers |
please test |
gcc11 build errors for Fireworks are fix ( https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5bc02a/17686/build-logs/Fireworks/Geometry/log.html ) |
-1 Failed Tests: RelVals-INPUT RelVals-INPUT
Expand to see more relval errors ...Comparison SummarySummary:
|
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5bc02a/17715/summary.html Comparison SummarySummary:
|
+1 |
Error log: https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc7_amd64_gcc11/CMSSW_12_1_X_2021-08-09-1100/Fireworks/Geometry
Error message:
PR description:
Added missing assignment of
dynamic_cast
forRectangularStripTopology
andTrapezoidalStripTopology
inADD_SISTRIP_TOPOLOGY
macroPR validation:
if this PR is a backport please specify the original PR and why you need to backport that PR:
Before submitting your pull requests, make sure you followed this checklist: