[GCC 11] Fix "this pointer is null" in RecoJets/JetProducers PileupJetIdAlgo #34772

iarspider · 2021-08-04T14:38:26Z

PR description:

Log file: https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc7_amd64_gcc11/CMSSW_12_1_X_2021-08-02-1100/RecoJets/JetProducers
Error message:

In function 'constexpr decltype (t1.eta()) reco::deltaR2(const T1&, const T2&) [with T1 = reco::Jet; T2 = reco::Candidate]',
    inlined from 'constexpr decltype (t1.eta()) reco::deltaR(const T1&, const T2&) [with T1 = reco::Jet; T2 = reco::Candidate]' at /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/e3e3f354f3bbc00899d20eeb240b2272/opt/cmssw/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-08-02-1100/src/DataFormats/Math/interface/deltaR.h:31:21,
    inlined from 'PileupJetIdentifier PileupJetIdAlgo::computeIdVariables(const reco::Jet*, float, const reco::Vertex*, const VertexCollection&, double, bool)' at /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/e3e3f354f3bbc00899d20eeb240b2272/opt/cmssw/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-08-02-1100/src/RecoJets/JetProducers/src/PileupJetIdAlgo.cc:668:42:
  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/e3e3f354f3bbc00899d20eeb240b2272/opt/cmssw/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-08-02-1100/src/DataFormats/Math/interface/deltaR.h:19:22: error: 'this' pointer is null [-Werror=nonnull]
    19 |     Float p2 = t2.phi();
      |                ~~~~~~^~
  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/e3e3f354f3bbc00899d20eeb240b2272/opt/cmssw/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-08-02-1100/src/DataFormats/Math/interface/deltaR.h:21:22: error: 'this' pointer is null [-Werror=nonnull]
    21 |     Float e2 = t2.eta();
      |                ~~~~~~^~

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

Before submitting your pull requests, make sure you followed this checklist:

verify that the PR is really intended for the chosen branch
verify that changes follow CMS Naming, Coding, And Style Rules
verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

Log file: https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc7_amd64_gcc11/CMSSW_12_1_X_2021-08-02-1100/RecoJets/JetProducers Error message: ``` In function 'constexpr decltype (t1.eta()) reco::deltaR2(const T1&, const T2&) [with T1 = reco::Jet; T2 = reco::Candidate]', inlined from 'constexpr decltype (t1.eta()) reco::deltaR(const T1&, const T2&) [with T1 = reco::Jet; T2 = reco::Candidate]' at /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/e3e3f354f3bbc00899d20eeb240b2272/opt/cmssw/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-08-02-1100/src/DataFormats/Math/interface/deltaR.h:31:21, inlined from 'PileupJetIdentifier PileupJetIdAlgo::computeIdVariables(const reco::Jet*, float, const reco::Vertex*, const VertexCollection&, double, bool)' at /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/e3e3f354f3bbc00899d20eeb240b2272/opt/cmssw/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-08-02-1100/src/RecoJets/JetProducers/src/PileupJetIdAlgo.cc:668:42: /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/e3e3f354f3bbc00899d20eeb240b2272/opt/cmssw/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-08-02-1100/src/DataFormats/Math/interface/deltaR.h:19:22: error: 'this' pointer is null [-Werror=nonnull] 19 | Float p2 = t2.phi(); | ~~~~~~^~ /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/e3e3f354f3bbc00899d20eeb240b2272/opt/cmssw/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-08-02-1100/src/DataFormats/Math/interface/deltaR.h:21:22: error: 'this' pointer is null [-Werror=nonnull] 21 | Float e2 = t2.eta(); | ~~~~~~^~ ```

iarspider · 2021-08-04T14:38:40Z

@cmsbuild please test for slc7_amd64_gcc11

cmsbuild · 2021-08-04T14:45:30Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34772/24436

This PR adds an extra 20KB to repository

cmsbuild · 2021-08-04T14:45:52Z

A new Pull Request was created by @iarspider for master.

It involves the following packages:

RecoJets/JetProducers (reconstruction)

@perrotta, @jpata, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @jdolen, @yslai, @jdamgov, @ahinzmann, @nhanvtran, @gkasieczka, @clelange, @schoef, @mariadalfonso, @seemasharmafnal this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2021-08-04T15:57:59Z

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fb97a5/17521/summary.html
COMMIT: 5c584d2
CMSSW: CMSSW_12_1_X_2021-08-02-1100/slc7_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34772/17521/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fb97a5/17521/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fb97a5/17521/git-merge-result

Build

I found compilation error when building:

/cvmfs/cms-ib.cern.ch/nweek-02692/slc7_amd64_gcc11/external/gcc/11.1.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/11.1.1/../../../../x86_64-unknown-linux-gnu/bin/ld: cannot find -lHeterogeneousCoreCUDACore
/cvmfs/cms-ib.cern.ch/nweek-02692/slc7_amd64_gcc11/external/gcc/11.1.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/11.1.1/../../../../x86_64-unknown-linux-gnu/bin/ld: cannot find -lCUDADataFormatsHGCal
/cvmfs/cms-ib.cern.ch/nweek-02692/slc7_amd64_gcc11/external/gcc/11.1.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/11.1.1/../../../../x86_64-unknown-linux-gnu/bin/ld: cannot find -lHeterogeneousCoreCUDAServices
/cvmfs/cms-ib.cern.ch/nweek-02692/slc7_amd64_gcc11/external/gcc/11.1.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/11.1.1/../../../../x86_64-unknown-linux-gnu/bin/ld: cannot find -lCUDADataFormatsCommon
/cvmfs/cms-ib.cern.ch/nweek-02692/slc7_amd64_gcc11/external/gcc/11.1.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/11.1.1/../../../../x86_64-unknown-linux-gnu/bin/ld: cannot find -lHeterogeneousCoreCUDAUtilities
collect2: error: ld returned 1 exit status
gmake: *** [tmp/slc7_amd64_gcc11/src/CondFormats/HGCalObjects/src/CondFormatsHGCalObjects/libCondFormatsHGCalObjects.so] Error 1
Leaving library rule at CondFormats/HGCalObjects
>> Leaving Package CondFormats/HGCalObjects
>> Package CondFormats/HGCalObjects built
>> Entering Package DQM/SiPixelPhase1Summary

smuzaffar · 2021-08-04T16:03:44Z

please test

cmsbuild · 2021-08-04T19:56:25Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fb97a5/17539/summary.html
COMMIT: 5c584d2
CMSSW: CMSSW_12_1_X_2021-08-03-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34772/17539/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

@cms-tsg-storm HLT menu migration to CMSSW 12_0_0_pre5 template [12_1_X] #34740
@zuoxunwu Online DQM: Add EMTF DQM plots on GEM information and their comparison to CSC inputs #34706
@mseidel42 Allow HcalPulseContainment timePhase definition as in SIM #34572
@smuzaffar [EventFilter] header cleanup to avoid private header usage #34739

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fb97a5/17539/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fb97a5/17539/git-merge-result

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 39
DQMHistoTests: Total histograms compared: 2998558
DQMHistoTests: Total failures: 11
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2998525
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 13814.586 KiB( 38 files compared)
DQMHistoSizes: changed ( 10024.0,... ): 767.477 KiB L1T/L1TStage2EMTF
Checked 165 log files, 37 edm output root files, 39 DQM output files
TriggerResults: found differences in 4 / 38 workflows

slava77 · 2021-08-05T00:07:24Z

@camclean @alefisico
please take a note of this bugfix in PileupJetIdAlgo.cc

@iarspider
please mention PileupJetIdAlgo in the PR title

slava77 · 2021-08-05T00:22:06Z

+reconstruction

for #34772 5c584d2

bugfix in are in PileupJetIdAlgo.cc dRLead2nd variable, which is apparently not used in the final ID; this is a member of the transient PileupJetIdentifier. So, no impact is expected on physics results.
jenkins tests pass and comparisons with the baseline show no (relevant) differences

cmsbuild · 2021-08-05T00:22:25Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2021-08-05T05:48:05Z

+1

cmsbuild added this to the CMSSW_12_1_X milestone Aug 4, 2021

cmsbuild added code-checks-pending orp-pending pending-signatures reconstruction-pending tests-started labels Aug 4, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 4, 2021

cmsbuild added tests-rejected and removed tests-started labels Aug 4, 2021

cmsbuild added tests-started and removed tests-rejected labels Aug 4, 2021

cmsbuild added tests-approved and removed tests-started labels Aug 4, 2021

cmsbuild added fully-signed reconstruction-approved and removed pending-signatures reconstruction-pending labels Aug 5, 2021

perrotta changed the title ~~[GCC 11] Fix "this pointer is null" in RecoJets/JetProducers~~ [GCC 11] Fix "this pointer is null" in RecoJets/JetProducers PileupJetIdAlgo Aug 5, 2021

cmsbuild added orp-approved and removed orp-pending labels Aug 5, 2021

cmsbuild merged commit 22c8559 into cms-sw:master Aug 5, 2021

iarspider deleted the patch-8 branch August 5, 2021 06:30

cmsbuild mentioned this pull request Aug 5, 2021

Add GEM unpacker in L1Repack FullMC and temporary load of GEM geometry to hltGetConfiguration #34788

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[GCC 11] Fix "this pointer is null" in RecoJets/JetProducers PileupJetIdAlgo #34772

[GCC 11] Fix "this pointer is null" in RecoJets/JetProducers PileupJetIdAlgo #34772

iarspider commented Aug 4, 2021

iarspider commented Aug 4, 2021

cmsbuild commented Aug 4, 2021

cmsbuild commented Aug 4, 2021

cmsbuild commented Aug 4, 2021

smuzaffar commented Aug 4, 2021

cmsbuild commented Aug 4, 2021

slava77 commented Aug 5, 2021

slava77 commented Aug 5, 2021

cmsbuild commented Aug 5, 2021

perrotta commented Aug 5, 2021

[GCC 11] Fix "this pointer is null" in RecoJets/JetProducers PileupJetIdAlgo #34772

[GCC 11] Fix "this pointer is null" in RecoJets/JetProducers PileupJetIdAlgo #34772

Conversation

iarspider commented Aug 4, 2021

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

iarspider commented Aug 4, 2021

cmsbuild commented Aug 4, 2021

cmsbuild commented Aug 4, 2021

cmsbuild commented Aug 4, 2021

Build

smuzaffar commented Aug 4, 2021

cmsbuild commented Aug 4, 2021

Comparison Summary

slava77 commented Aug 5, 2021

slava77 commented Aug 5, 2021

cmsbuild commented Aug 5, 2021

perrotta commented Aug 5, 2021