-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TkDQM: Fill barycenter plots at EndRun #34720
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34720/24359
|
A new Pull Request was created by @dmeuser for master. It involves the following packages:
@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-df3566/17415/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
The new pixel barycenter plots added in #34312 are now filled at EndRun and not at EndLuminosityBlock, which enables comparisons between different runs.
PR validation:
The changes have been tested by running
runTheMatrix.py -l 136.89
, which run without any failed steps and produces the desired additional histograms.if this PR is a backport please specify the original PR and why you need to backport that PR:
This PR is not a backport.
cc:
@mmusich, @arossi83, @sroychow