Temporarily disable the GEM-CSC triggers #34693

dildick · 2021-07-29T14:40:33Z

PR description:

Temporarily disable the GEM-CSC triggers until the GEM-CSC lookup tables (for coordinate conversion and matching) are contained in a new ES object and are loaded though the eventsetup, rather than through the CSCLUTReader for each chamber in each event.

PR validation:

PR #34597 relval tests are failing only for Run-3 and Phase-2 scenarios, not Run-1 or Run-2. By disabling GEM-CSC temporarily, this should allow those relval tests to run.

if this PR is a backport please specify the original PR and why you need to backport that PR:

N.A.

Before submitting your pull requests, make sure you followed this checklist:

verify that the PR is really intended for the chosen branch
verify that changes follow CMS Naming, Coding, And Style Rules
verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

Temporarily disable the GEM-CSC triggers until the GEM-CSC lookup tables (for coordinate conversion and matching) are contained in a new ES object and are loaded though the eventsetup, rather than through the CSCLUTReader.

cmsbuild · 2021-07-29T14:49:35Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34693/24321

This PR adds an extra 12KB to repository

cmsbuild · 2021-07-29T14:50:11Z

A new Pull Request was created by @dildick (Sven Dildick) for master.

It involves the following packages:

L1Trigger/CSCTriggerPrimitives (l1)

@cmsbuild, @rekovic, @cecilecaillol can you please review it and eventually sign? Thanks.
@valuev, @ptcox, @Martin-Grunewald this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

perrotta · 2021-07-29T14:54:08Z

please test

cmsbuild · 2021-07-29T17:37:39Z

-1

Failed Tests: RelVals RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-88e8dc/17340/summary.html
COMMIT: 9c435d8
CMSSW: CMSSW_12_0_X_2021-07-29-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34693/17340/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

312.0

----- Begin Fatal Exception 29-Jul-2021 17:46:40 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'validation_step'
   [2] Calling method for module CSCDigiValidation/'cscDigiValidation'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: MuonDigiCollection<GEMDetId,GEMCoPadDigi>
Looking for module label: simCscTriggerPrimitiveDigis
Looking for productInstanceName: 

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

11634.0

----- Begin Fatal Exception 29-Jul-2021 18:25:02 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 2 stream: 0
   [1] Running path 'validation_step'
   [2] Calling method for module CSCDigiValidation/'cscDigiValidation'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: MuonDigiCollection<GEMDetId,GEMCoPadDigi>
Looking for module label: simCscTriggerPrimitiveDigis
Looking for productInstanceName: 

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

12434.0

----- Begin Fatal Exception 29-Jul-2021 18:33:36 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 2 stream: 0
   [1] Running path 'validation_step'
   [2] Calling method for module CSCDigiValidation/'cscDigiValidation'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: MuonDigiCollection<GEMDetId,GEMCoPadDigi>
Looking for module label: simCscTriggerPrimitiveDigis
Looking for productInstanceName: 

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

RelVals-INPUT

140.56140.56_RunHI2018+RunHI2018+RECOHID18+HARVESTDHI18/step2_RunHI2018+RunHI2018+RECOHID18+HARVESTDHI18.log
11601.011601.0_SingleElectronPt10+2021+SingleElectronPt10_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA/step2_SingleElectronPt10+2021+SingleElectronPt10_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA.log
11602.011602.0_SingleElectronPt35+2021+SingleElectronPt35_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA/step2_SingleElectronPt35+2021+SingleElectronPt35_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA.log

Expand to see more relval errors ...

dildick · 2021-07-29T20:07:58Z

This should run

11634.0_TTbar_14TeV+2021+TTbar_14TeV_TuneCP5_GenSim+Digi+Reco+HARVEST+ALCA Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED Step4-PASSED  - time date Thu Jul 29 14:55:37 2021-date Thu Jul 29 13:35:23 2021; exit: 0 0 0 0 0
1 1 1 1 1 tests passed, 0 0 0 0 0 failed

and

312.0_Pyquen_ZeemumuJets_pt10_2760GeV_2021+Pyquen_ZeemumuJets_pt10_2760GeV_2021+DIGIHI2021MIX+RECOHI2021MIX+HARVESTHI2021PPRECO Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED  - time date Thu Jul 29 13:33:12 2021-date Thu Jul 29 12:56:48 2021; exit: 0 0 0 0
1 1 1 1 tests passed, 0 0 0 0 failed

cmsbuild · 2021-07-29T20:12:43Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34693/24328

This PR adds an extra 16KB to repository

cmsbuild · 2021-07-29T20:13:09Z

Pull request #34693 was updated. @andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @rekovic, @jfernan2, @cecilecaillol, @rvenditti can you please check and sign again.

tvami · 2021-07-29T20:23:35Z

@cmsbuild , please test

cmsbuild · 2021-07-30T01:13:59Z

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-88e8dc/17347/summary.html
COMMIT: 05c909e
CMSSW: CMSSW_12_0_X_2021-07-29-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34693/17347/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

11634.2411634.24_TTbar_14TeV+2021_0T+TTbar_14TeV_TuneCP5_GenSimINPUT+Digi+Reco+HARVEST+ALCA/step2_TTbar_14TeV+2021_0T+TTbar_14TeV_TuneCP5_GenSimINPUT+Digi+Reco+HARVEST+ALCA.log
11634.50111634.501_TTbar_14TeV+2021_Patatrack_PixelOnlyCPU+TTbar_14TeV_TuneCP5_GenSimINPUT+Digi+Reco+HARVEST/step2_TTbar_14TeV+2021_Patatrack_PixelOnlyCPU+TTbar_14TeV_TuneCP5_GenSimINPUT+Digi+Reco+HARVEST.log
11601.011601.0_SingleElectronPt10+2021+SingleElectronPt10_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA/step2_SingleElectronPt10+2021+SingleElectronPt10_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA.log

Expand to see more relval errors ...

Comparison Summary

Summary:

No significant changes to the logs found
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 31 differences found in the comparisons
DQMHistoTests: Total files compared: 39
DQMHistoTests: Total histograms compared: 2998564
DQMHistoTests: Total failures: 142
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 2998399
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.004 KiB( 38 files compared)
DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
Checked 165 log files, 37 edm output root files, 39 DQM output files
TriggerResults: no differences found

jfernan2 · 2021-07-30T07:37:17Z

+1

dildick · 2021-08-02T15:20:15Z

Hi, can someone restart the tests, please?

perrotta · 2021-08-02T15:22:18Z

please test

cmsbuild · 2021-08-02T21:05:02Z

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-88e8dc/17432/summary.html
COMMIT: 05c909e
CMSSW: CMSSW_12_1_X_2021-08-02-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34693/17432/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

11634.50111634.501_TTbar_14TeV+2021_Patatrack_PixelOnlyCPU+TTbar_14TeV_TuneCP5_GenSimINPUT+Digi+Reco+HARVEST/step2_TTbar_14TeV+2021_Patatrack_PixelOnlyCPU+TTbar_14TeV_TuneCP5_GenSimINPUT+Digi+Reco+HARVEST.log
11601.011601.0_SingleElectronPt10+2021+SingleElectronPt10_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA/step2_SingleElectronPt10+2021+SingleElectronPt10_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA.log
11602.011602.0_SingleElectronPt35+2021+SingleElectronPt35_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA/step2_SingleElectronPt35+2021+SingleElectronPt35_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA.log

Expand to see more relval errors ...

Comparison Summary

Summary:

No significant changes to the logs found
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 30 differences found in the comparisons
DQMHistoTests: Total files compared: 39
DQMHistoTests: Total histograms compared: 2998564
DQMHistoTests: Total failures: 138
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2998404
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
Checked 165 log files, 37 edm output root files, 39 DQM output files
TriggerResults: no differences found

dildick · 2021-08-03T16:25:09Z

@perrotta Perhaps at this point we should consider merging the PR without having done successful tests? The PR intends to prevent crashes in relvals by temporarily shutting off parts of the CSC trigger that request large lookup tables. But those relval crashes are stopping the PR itself.

tvami · 2021-08-03T16:43:41Z

@cmsbuild , please test

(other tests seem to be working now)

cmsbuild · 2021-08-03T21:48:52Z

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-88e8dc/17487/summary.html
COMMIT: 05c909e
CMSSW: CMSSW_12_1_X_2021-08-03-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34693/17487/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

11601.011601.0_SingleElectronPt10+2021+SingleElectronPt10_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA/step2_SingleElectronPt10+2021+SingleElectronPt10_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA.log
11602.011602.0_SingleElectronPt35+2021+SingleElectronPt35_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA/step2_SingleElectronPt35+2021+SingleElectronPt35_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA.log
11603.011603.0_SingleElectronPt1000+2021+SingleElectronPt1000_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA/step2_SingleElectronPt1000+2021+SingleElectronPt1000_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA.log

Expand to see more relval errors ...

Comparison Summary

Summary:

No significant changes to the logs found
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 34 differences found in the comparisons
DQMHistoTests: Total files compared: 39
DQMHistoTests: Total histograms compared: 2998564
DQMHistoTests: Total failures: 144
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2998398
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
Checked 165 log files, 37 edm output root files, 39 DQM output files
TriggerResults: no differences found

dildick · 2021-08-04T18:06:01Z

Superseded by #34779.

Temporarily disable the GEM-CSC triggers

9c435d8

Temporarily disable the GEM-CSC triggers until the GEM-CSC lookup tables (for coordinate conversion and matching) are contained in a new ES object and are loaded though the eventsetup, rather than through the CSCLUTReader.

cmsbuild added this to the CMSSW_12_0_X milestone Jul 29, 2021

cmsbuild added code-checks-pending l1-pending orp-pending pending-signatures tests-pending labels Jul 29, 2021

dildick mentioned this pull request Jul 29, 2021

Slowness in cmsRun starts #34633

Closed

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 29, 2021

cmsbuild added tests-started and removed tests-pending labels Jul 29, 2021

cmsbuild added tests-rejected and removed tests-started labels Jul 29, 2021

temporarily disable GEMs in the CSC matcher

05c909e

cmsbuild added code-checks-pending dqm-pending tests-pending and removed code-checks-approved tests-rejected labels Jul 29, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 29, 2021

cmsbuild added tests-started and removed tests-pending labels Jul 29, 2021

cmsbuild added tests-rejected and removed tests-started labels Jul 30, 2021

smuzaffar modified the milestones: CMSSW_12_0_X, CMSSW_12_1_X Jul 30, 2021

cmsbuild added dqm-approved and removed dqm-pending labels Jul 30, 2021

cmsbuild added tests-started and removed tests-rejected labels Aug 2, 2021

cmsbuild added tests-rejected and removed tests-started labels Aug 2, 2021

cmsbuild added tests-started and removed tests-rejected labels Aug 3, 2021

cmsbuild added tests-rejected and removed tests-started labels Aug 3, 2021

dildick mentioned this pull request Aug 4, 2021

Move CSC trigger and GEM-CSC trigger lookup tables into eventsetup objects (CCLUT-17) #34779

Merged

dildick closed this Aug 4, 2021

dildick deleted the patch-1 branch August 4, 2021 20:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Temporarily disable the GEM-CSC triggers #34693

Temporarily disable the GEM-CSC triggers #34693

dildick commented Jul 29, 2021 •

edited

Loading

cmsbuild commented Jul 29, 2021

cmsbuild commented Jul 29, 2021

perrotta commented Jul 29, 2021

cmsbuild commented Jul 29, 2021

dildick commented Jul 29, 2021

cmsbuild commented Jul 29, 2021

cmsbuild commented Jul 29, 2021

tvami commented Jul 29, 2021

cmsbuild commented Jul 30, 2021

jfernan2 commented Jul 30, 2021

dildick commented Aug 2, 2021

perrotta commented Aug 2, 2021

cmsbuild commented Aug 2, 2021

dildick commented Aug 3, 2021

tvami commented Aug 3, 2021 •

edited

Loading

cmsbuild commented Aug 3, 2021

dildick commented Aug 4, 2021

Temporarily disable the GEM-CSC triggers #34693

Temporarily disable the GEM-CSC triggers #34693

Conversation

dildick commented Jul 29, 2021 • edited Loading

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Jul 29, 2021

cmsbuild commented Jul 29, 2021

perrotta commented Jul 29, 2021

cmsbuild commented Jul 29, 2021

RelVals

RelVals-INPUT

dildick commented Jul 29, 2021

cmsbuild commented Jul 29, 2021

cmsbuild commented Jul 29, 2021

tvami commented Jul 29, 2021

cmsbuild commented Jul 30, 2021

RelVals-INPUT

Comparison Summary

jfernan2 commented Jul 30, 2021

dildick commented Aug 2, 2021

perrotta commented Aug 2, 2021

cmsbuild commented Aug 2, 2021

RelVals-INPUT

Comparison Summary

dildick commented Aug 3, 2021

tvami commented Aug 3, 2021 • edited Loading

cmsbuild commented Aug 3, 2021

RelVals-INPUT

Comparison Summary

dildick commented Aug 4, 2021

dildick commented Jul 29, 2021 •

edited

Loading

tvami commented Aug 3, 2021 •

edited

Loading