Run3-gex83L Modify the remaining calorimeter SD's to access objects from EventSetup correctly #34589

bsunanda · 2021-07-22T13:51:03Z

PR description:

Modify the remaining calorimeter SD's to access objects from EventSetup correctly

PR validation:

Use the runTheMatrix test workflows

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

cmsbuild · 2021-07-22T13:59:19Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34589/24143

This PR adds an extra 48KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34589/24143/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34589/24143/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2021-07-22T14:15:53Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34589/24144

This PR adds an extra 52KB to repository

cmsbuild · 2021-07-22T14:16:15Z

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

SimG4CMS/Calo (simulation)
SimG4Core/Application (simulation)

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @cvuosalo, @rovere, @thomreis, @felicepantaleo, @simonepigazzini, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

bsunanda · 2021-07-23T17:25:19Z

@cmsbuild Please test

cmsbuild · 2021-07-23T20:50:39Z

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c900c6/17153/summary.html
COMMIT: 7444060
CMSSW: CMSSW_12_0_X_2021-07-23-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34589/17153/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test trackerMaterialAnalysisPlots had ERRORS

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 5 differences found in the comparisons
DQMHistoTests: Total files compared: 39
DQMHistoTests: Total histograms compared: 2998564
DQMHistoTests: Total failures: 12
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 2998529
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.004 KiB( 38 files compared)
DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
Checked 165 log files, 37 edm output root files, 39 DQM output files
TriggerResults: no differences found

bsunanda · 2021-07-24T04:16:48Z

@cmsbuild Please test

cmsbuild · 2021-07-24T07:55:38Z

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c900c6/17161/summary.html
COMMIT: 7444060
CMSSW: CMSSW_12_0_X_2021-07-23-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34589/17161/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test trackerMaterialAnalysisPlots had ERRORS

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 39
DQMHistoTests: Total histograms compared: 2998564
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2998541
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
Checked 165 log files, 37 edm output root files, 39 DQM output files
TriggerResults: no differences found

bsunanda · 2021-07-24T23:43:04Z

@qliphy @perrotta All the failures are for missing input files. Please take care of that

qliphy · 2021-07-25T01:52:30Z

@bsunanda

I noticed from e..g [1]
A fatal system signal has occurred: external termination request
and
Waiting for stacktrace completion failed: timed out waiting for GDB to complete.
Probably it is just a glitch.

[1] https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c900c6/17171/runTheMatrixINPUT-results/11634.511_TTbar_14TeV+2021_Patatrack_ECALOnlyCPU+TTbar_14TeV_TuneCP5_GenSimINPUT+Digi+Reco+HARVEST/step2_TTbar_14TeV+2021_Patatrack_ECALOnlyCPU+TTbar_14TeV_TuneCP5_GenSimINPUT+Digi+Reco+HARVEST.log

qliphy · 2021-07-25T01:52:51Z

please test

bsunanda · 2021-07-25T02:32:45Z

@cmsbuild Please test

cmsbuild · 2021-07-25T08:24:19Z

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c900c6/17173/summary.html
COMMIT: e763acb
CMSSW: CMSSW_12_0_X_2021-07-24-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34589/17173/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

11601.011601.0_SingleElectronPt10+2021+SingleElectronPt10_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA/step2_SingleElectronPt10+2021+SingleElectronPt10_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA.log
11603.011603.0_SingleElectronPt1000+2021+SingleElectronPt1000_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA/step2_SingleElectronPt1000+2021+SingleElectronPt1000_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA.log
11602.011602.0_SingleElectronPt35+2021+SingleElectronPt35_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA/step2_SingleElectronPt35+2021+SingleElectronPt35_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA.log

Expand to see more relval errors ...

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 39
DQMHistoTests: Total histograms compared: 2998564
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 2998535
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.004 KiB( 38 files compared)
DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
Checked 165 log files, 37 edm output root files, 39 DQM output files
TriggerResults: no differences found

bsunanda · 2021-07-25T13:00:50Z

@cmsbuild Please test

cmsbuild · 2021-07-25T16:33:13Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c900c6/17180/summary.html
COMMIT: e763acb
CMSSW: CMSSW_12_0_X_2021-07-25-0000/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34589/17180/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 6 differences found in the comparisons
DQMHistoTests: Total files compared: 39
DQMHistoTests: Total histograms compared: 2998564
DQMHistoTests: Total failures: 12
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 2998529
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.004 KiB( 38 files compared)
DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
Checked 165 log files, 37 edm output root files, 39 DQM output files
TriggerResults: no differences found

bsunanda · 2021-07-26T00:10:51Z

@civanch Please approve this. This is the last PR for the SD's

civanch · 2021-07-26T07:06:02Z

+1

cmsbuild · 2021-07-26T07:06:23Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2021-07-26T07:42:11Z

@bsunanda according to the static analyzer there is still one more file to be migrated: /SimG4CMS/Calo/src/HcalTestAnalysis.cc
There is no need to hold this PR for it, as it can be deferred to a forthcoming PR

perrotta · 2021-07-26T07:42:21Z

+1

cmsbuild added this to the CMSSW_12_0_X milestone Jul 22, 2021

cmsbuild added code-checks-pending orp-pending pending-signatures simulation-pending tests-pending labels Jul 22, 2021

cmsbuild added code-checks-rejected code-checks-pending and removed code-checks-pending code-checks-rejected labels Jul 22, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 22, 2021

bsunanda mentioned this pull request Jul 22, 2021

Run3-TB62 Modify HGCal TB related scenarios and scripts in view of changed initialization of SDs #34592

Merged

cmsbuild mentioned this pull request Jul 22, 2021

Fixed finecalo performance #34597

Merged

cmsbuild added tests-started and removed tests-pending labels Jul 23, 2021

bsunanda mentioned this pull request Jul 23, 2021

Run3-hcx304 Update the scripts for the combined ECAL+HCAL TB simulation #34609

Merged

cmsbuild added tests-rejected and removed tests-started labels Jul 23, 2021

cmsbuild added tests-started and removed tests-rejected labels Jul 24, 2021

cmsbuild added tests-rejected and removed tests-started labels Jul 24, 2021

cmsbuild added tests-started and removed tests-rejected labels Jul 25, 2021

cmsbuild added tests-rejected and removed tests-started labels Jul 25, 2021

cmsbuild added tests-started and removed tests-rejected labels Jul 25, 2021

cmsbuild added tests-approved and removed tests-started labels Jul 25, 2021

bsunanda mentioned this pull request Jul 25, 2021

Unit failure on Validation/Geometry #34601

Closed

cmsbuild added fully-signed simulation-approved and removed pending-signatures simulation-pending labels Jul 26, 2021

cmsbuild added orp-approved and removed orp-pending labels Jul 26, 2021

cmsbuild merged commit 49cd0eb into cms-sw:master Jul 26, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Run3-gex83L Modify the remaining calorimeter SD's to access objects from EventSetup correctly #34589

Run3-gex83L Modify the remaining calorimeter SD's to access objects from EventSetup correctly #34589

bsunanda commented Jul 22, 2021

cmsbuild commented Jul 22, 2021

cmsbuild commented Jul 22, 2021

cmsbuild commented Jul 22, 2021

bsunanda commented Jul 23, 2021

cmsbuild commented Jul 23, 2021

bsunanda commented Jul 24, 2021

cmsbuild commented Jul 24, 2021

bsunanda commented Jul 24, 2021

qliphy commented Jul 25, 2021

qliphy commented Jul 25, 2021

bsunanda commented Jul 25, 2021

cmsbuild commented Jul 25, 2021

bsunanda commented Jul 25, 2021

cmsbuild commented Jul 25, 2021

bsunanda commented Jul 26, 2021

civanch commented Jul 26, 2021

cmsbuild commented Jul 26, 2021

perrotta commented Jul 26, 2021

perrotta commented Jul 26, 2021

Run3-gex83L Modify the remaining calorimeter SD's to access objects from EventSetup correctly #34589

Run3-gex83L Modify the remaining calorimeter SD's to access objects from EventSetup correctly #34589

Conversation

bsunanda commented Jul 22, 2021

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Jul 22, 2021

cmsbuild commented Jul 22, 2021

cmsbuild commented Jul 22, 2021

bsunanda commented Jul 23, 2021

cmsbuild commented Jul 23, 2021

Unit Tests

Comparison Summary

bsunanda commented Jul 24, 2021

cmsbuild commented Jul 24, 2021

Unit Tests

Comparison Summary

bsunanda commented Jul 24, 2021

qliphy commented Jul 25, 2021

qliphy commented Jul 25, 2021

bsunanda commented Jul 25, 2021

cmsbuild commented Jul 25, 2021

RelVals-INPUT

Comparison Summary

bsunanda commented Jul 25, 2021

cmsbuild commented Jul 25, 2021

Comparison Summary

bsunanda commented Jul 26, 2021

civanch commented Jul 26, 2021

cmsbuild commented Jul 26, 2021

perrotta commented Jul 26, 2021

perrotta commented Jul 26, 2021