PPS geometry bug fix: missing file

[fabferro]

PR description:

Putting back xml file removed by mistake in PR#34499.

[smuzaffar]

@fabferro , looks like, in PR #34499, this file was renamed( moved) from RP_Vertical_Device/2021/v1/RP_Vertical_Device.xml to RP_Vertical_Device/2021/Simu/v1/RP_Vertical_Device.xml . Do you want to keep RP_Vertical_Device/2021/Simu/v1/RP_Vertical_Device.xml too ( which is identical to RP_Vertical_Device/2021/v1/RP_Vertical_Device.xml )

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34588/24142

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @fabferro (Fabrizio Ferro) for master.

It involves the following packages:

• Geometry/VeryForwardData (geometry)

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@bsunanda, @jan-kaspar, @fabiocos this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

[qliphy]

type bugfix

as discussed in #34499 (comment)

[fabferro]

@fabferro , looks like, in PR #34499, this file was renamed( moved) from RP_Vertical_Device/2021/v1/RP_Vertical_Device.xml to RP_Vertical_Device/2021/Simu/v1/RP_Vertical_Device.xml . Do you want to keep RP_Vertical_Device/2021/Simu/v1/RP_Vertical_Device.xml too ( which is identical to RP_Vertical_Device/2021/v1/RP_Vertical_Device.xml )

Yes, please, we need both at this stage.
v1/RP_Verticel_Device.xml will be deleted when P4 will become deprecated.

[qliphy]

@cms-sw/geometry-l2 Do you have any comment? We would like to merge this and include in next IB to fix issues.

[cvuosalo]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1

[qliphy]

merge

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a067d4/17090/summary.html
COMMIT: e4fde44
CMSSW: CMSSW_12_0_X_2021-07-21-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34588/17090/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @civanch Enable general gamma process for Geant4 #34564
• @jshlee GEM unpacker - updated DAQ dataformat and new DAQ status collections #34504
• @carolinecollard Remove 50ns-labeled dynamic inefficiency payload usage from SiPixelDigitizer #34502
• @Dr15Jones Added WaitingTask Chain #34413
• @guitargeek Build files cleaning #34544

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a067d4/17090/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a067d4/17090/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test materialBudgetTrackerPlots had ERRORS
---> test trackerMaterialAnalysisPlots had ERRORS
---> test materialBudgetHGCalPlots had ERRORS

Comparison Summary

There are some workflows for which there are errors in the baseline:
11634.911 step 1
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

• No significant changes to the logs found
• Reco comparison results: 52057 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2788434
• DQMHistoTests: Total failures: 295421
• DQMHistoTests: Total nulls: 204
• DQMHistoTests: Total successes: 2492787
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 4.207 KiB( 37 files compared)
• DQMHistoSizes: changed ( 10224.0 ): 0.010 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 250202.181 ): 0.240 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 25202.0 ): -0.361 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• DQMHistoSizes: changed ( 7.3 ): 4.322 KiB SiStrip/MechanicalView
• Checked 161 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: found differences in 12 / 37 workflows

[fabferro]

It doesn't seem to me that the errors in the Unit Tests are due to this PR. Should I be wrong please let me know.

[qliphy]

This PR has fixed many other IB issues. Thanks!

The remaining ones are not related to this PR:
#34601
#34587