Build files cleaning

[guitargeek]

PR description:

Another quick BuildFile cleaning PR in the style of many before (for example #34191).

This PR cleans unnecessary includes from CMSSW BuildFiles that were recently added for 12_0_0_pre4. Furthermore, unused boost dependencies are removed from the Validation subsystem.

PR validation:

CMSSW compiles.

if this PR is a backport please specify the original PR and why you need to backport that PR:

No backport intended.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34544/24068

• This PR adds an extra 36KB to repository

[cmsbuild]

A new Pull Request was created by @guitargeek (Jonas Rembser) for master.

It involves the following packages:

• CalibTracker/SiStripESProducers (alca)
• CalibTracker/SiStripQuality (alca)
• DQM/TrackerRemapper (dqm)
• Geometry/CaloTopology (geometry)
• L1Trigger/L1TTrackMatch (upgrade, l1)
• RecoEgamma/EgammaIsolationAlgos (reconstruction)
• RecoMuon/L2MuonProducer (hlt, reconstruction)
• SimG4Core/Application (simulation)
• Validation/CaloTowers (dqm)
• Validation/CheckOverlap (geometry)
• Validation/EcalHits (dqm)
• Validation/EcalRecHits (dqm)
• Validation/Geometry (geometry, dqm)
• Validation/HcalDigis (dqm)
• Validation/HcalHits (dqm)
• Validation/HcalRecHits (dqm)
• Validation/MuonGEMHits (dqm)
• Validation/MuonGEMRecHits (dqm)
• Validation/MuonME0Validation (dqm)
• Validation/RecoB (dqm)
• Validation/RecoMuon (dqm)
• Validation/RecoPixelVertexing (dqm)
• Validation/RecoTrack (dqm)
• Validation/RecoVertex (dqm)
• Validation/SiTrackerPhase2V (dqm)
• Validation/TrackerDigis (dqm)
• Validation/TrackerRecHits (dqm)
• Validation/TrackingMCTruth (dqm)

@andrius-k, @ianna, @kpedro88, @Martin-Grunewald, @rekovic, @tlampen, @pohsun, @cecilecaillol, @perrotta, @civanch, @yuanchao, @makortel, @ErnestaP, @ahmad3213, @cmsbuild, @Dr15Jones, @cvuosalo, @mdhildreth, @jfernan2, @slava77, @jpata, @francescobrivio, @malbouis, @kmaeshima, @srimanob, @tvami, @rvenditti can you please review it and eventually sign? Thanks.
@wmtford, @echabert, @emilbols, @felicepantaleo, @jainshilpi, @abbiendi, @robervalwalsh, @argiro, @jshlee, @bsunanda, @fioriNTU, @thomreis, @rishabhCMS, @threus, @mmusich, @slomeo, @venturia, @hdelanno, @JyothsnaKomaragiri, @makortel, @abdoulline, @JanFSchulte, @jhgoh, @dgulhan, @apsallid, @sscruz, @cericeci, @sroychow, @simonepigazzini, @pieterdavid, @lgray, @rociovilar, @Sam-Harper, @cvuosalo, @GiacomoSguazzoni, @tocheng, @VinInn, @bellan, @rovere, @jandrea, @idebruyn, @ebrondol, @mtosi, @fabiocos, @rbartek, @arossi83, @watson-ij, @HuguesBrun, @Martin-Grunewald, @rchatter, @trocino, @vargasa, @varuns23, @gbenelli, @Fedespring, @calderona, @hatakeyamak, @sobhatta, @lecriste, @afiqaize, @andrzejnovak, @ram1123 this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

please test

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fd3e23/16969/summary.html
COMMIT: 78faedd
CMSSW: CMSSW_12_0_X_2021-07-18-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34544/16969/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test TestDQMServicesDemo had ERRORS

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-fd3e23/11634.912_TTbar_14TeV+2021_DD4hepDB+TTbar_14TeV_TuneCP5_GenSim+Digi+Reco+HARVEST+ALCA

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 2996268
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2996245
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[guitargeek]

The failures are not related to this PR right?

[qliphy]

The failures are not related to this PR right?

Right, as reported in #34520
should be fixed by #34532 which is now merged.

[slava77]

+reconstruction

for #34544 78faedd

• technical code changes are in line with the PR description
• jenkins tests pass and comparisons with the baseline show no differences

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fd3e23/17024/summary.html
COMMIT: 78faedd
CMSSW: CMSSW_12_0_X_2021-07-20-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34544/17024/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test EcalDCS_O2O_test had ERRORS
---> test EcalDAQ_O2O_test had ERRORS
---> test EcalLaser_O2O_test had ERRORS

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 2996268
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2996245
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[civanch]

+1

[tvami]

@cmsbuild , please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fd3e23/17057/summary.html
COMMIT: 78faedd
CMSSW: CMSSW_12_0_X_2021-07-20-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34544/17057/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

• No significant changes to the logs found
• Reco comparison results: 1222 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 2996268
• DQMHistoTests: Total failures: 3672
• DQMHistoTests: Total nulls: 19
• DQMHistoTests: Total successes: 2992555
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 45.703 KiB( 38 files compared)
• DQMHistoSizes: changed ( 140.53 ): 44.531 KiB Hcal/DigiRunHarvesting
• DQMHistoSizes: changed ( 140.53 ): 1.172 KiB RPC/DCSInfo
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1
Changes in wf 140.53 are due to different files in step1_dasquery.log

[cecilecaillol]

+l1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1