Improve MessageLogger Context Handling for ProcessBlock Transitions #34506
Conversation
Affects only MessageLogger context strings. Handle the case where ProcessBlock transitions go into a nonblocking wait and TBB runs another module on the same thread. Handles this context the same as for Run transitions.
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34506/23995
|
|
A new Pull Request was created by @wddgit (W. David Dagenhart) for master. It involves the following packages:
@makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test (note this is based on the master branch 3 commits ahead of the last IB, hopefully that doesn't cause problems, but if it does I will rerun the tests tomorrow.) |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5ebeac/16862/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Comparison SummarySummary:
|
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2) |
cmsbuild
added
core-approved
fully-signed
and removed
core-pending
pending-signatures
labels
|
+1 |
PR description:
Affects only MessageLogger context strings during ProcessBlock transitions.
Change the MessageLogger code so that it handles the ProcessBlock case in a manner as close as possible to the way it is handled for Runs. Before this it was more similar to the way beginJob was handled.
The main practical difference is that this can now properly deal with the case where a module ProcessBlock function goes into a wait that could allow other TBB tasks to run and another module runs its ProcessBlock transition before execution goes back to the original module and we want the context to be reset again for the original module. This does not currently happen anywhere, but it is possible. Logically the code is also cleaner and easier to understand if it is the same as in the Run case.
PR validation:
Relies on existing tests. One unit test is updated because of a minor change to make the context string more similar to that used for Runs.