-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SiPixelVCal
Payload Inspector
#34375
Conversation
type bug-fix |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34375/23758
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages: CondCore/SiPixelPlugins @ggovi, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-130a40/16537/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
The
SiPixelVCal
payload inspector was never used for lack of uploaded payloads. Now that the commissioning procedures for the Pixel gain calibration for Run-3 have started few bugs hindering the correct display of conditions at the payload inspector in CondDB were found. These are fixed in this PR (b8f074a).I profit to:
SiPixelLorentzAngle_PayloadInspector
to use class templates from Improvements for Payload inspector #29622 in commit: 9e4545bPR validation:
Several standalone tests (outputs available here) plus
scramv1 b runtests
passedif this PR is a backport please specify the original PR and why you need to backport that PR:
NA