Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Make stop/sbottom R-hadrons use the cloud model #34498

Merged
merged 1 commit into from
Jul 16, 2021

Conversation

tvami
Copy link
Contributor

@tvami tvami commented Jul 15, 2021

PR description:

See description in #34459

if this PR is a backport please specify the original PR and why you need to backport that PR:

This is a backport of #34459
and needed for MC production for HSCP particle simulations in UL

cc @tadams16 @carolinecollard

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @tvami (Tamas Vami) for CMSSW_10_6_X.

It involves the following packages:

  • SimG4Core/CustomPhysics (simulation)

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @cvuosalo, @rovere, @bsunanda, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

@tvami tvami changed the title [Backport] Change isRHadron() to isgluinoHadron() and added stop and sbottom to conditional in CustomPhysicsList [Backport] Make stop/sbottom R-hadrons use the cloud model Jul 15, 2021
@tvami
Copy link
Contributor Author

tvami commented Jul 15, 2021

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-60c6f7/16850/summary.html
COMMIT: 4c373dd
CMSSW: CMSSW_10_6_X_2021-07-11-0000/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34498/16850/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 3215686
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3215351
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 143 log files, 29 edm output root files, 35 DQM output files
  • TriggerResults: no differences found

@civanch
Copy link
Contributor

civanch commented Jul 15, 2021

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Jul 16, 2021

type bugfix

@qliphy
Copy link
Contributor

qliphy commented Jul 16, 2021

+1

@cmsbuild cmsbuild merged commit 1190290 into cms-sw:CMSSW_10_6_X Jul 16, 2021
@tvami
Copy link
Contributor Author

tvami commented Jul 16, 2021

Hi @qliphy is there a plan for a patch in 10_6_X in which this can go to?

@qliphy
Copy link
Contributor

qliphy commented Jul 16, 2021

@tvami How urgent is that?

@cms-sw/xpog-l2 @rappoccio

@tvami
Copy link
Contributor Author

tvami commented Jul 16, 2021

@tvami How urgent is that?

It's not super urgent, we'd just like to understand what the plans are, if there is some time when it would be best to plug this in.

@rappoccio
Copy link
Contributor

We should probably discuss at the ORP meeting Tuesday. Are there plans for imminent papers that require this? If so we would need some kind of discussion / request / approval w/ Physics Coordination @arizzi.

@tvami
Copy link
Contributor Author

tvami commented Aug 23, 2021

Hi @qliphy @perrotta I wanted to wait for (the backport of) #34640 to get merged, but since it's going very slowly, maybe it's time for having a new 10_6_X release now that we are after a month of this PR? Is there anything else that's forseen to enter 10_6_X soon?

@qliphy
Copy link
Contributor

qliphy commented Aug 24, 2021

@tvami Yes, we will make a 10_6_X this week, which will also include several features from GEN (will report at PPD general this Thursday) and PdmV.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants