Make stop/sbottom R-hadrons use the cloud model

[tvami]

PR description:

This PR fixes a bug, namely that the stop/sbottom R-hadrons were not added in CustomPhysicsList from CMSSW_8_0_X, so they do not use the cloud model. Fix can be easily done by renaming is_Rhadron() to s_isgluinoHadron to reflect what the code is really doing and add the stop and sbottom to the CustomPhysicsList.
More details
https://indico.cern.ch/event/1012481/contributions/4248900/attachments/2198166/3716919/SlidesMCTests20210226.pdf
and
https://indico.cern.ch/event/963050/contributions/4051179/attachments/2116681/3565085/SlidesMCDebug20201006.pdf

PR validation:

Code compiles, physics validation done in the talks linked above

if this PR is a backport please specify the original PR and why you need to backport that PR:

This is not a backport, but a backport is planned

cc: @tadams16 @carolinecollard

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34459/23904

• This PR adds an extra 20KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34459/23904/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34459/23904/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34459/23907

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @tvami (Tamas Vami) for master.

It involves the following packages:

• SimG4Core/CustomPhysics (simulation)

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @cvuosalo, @rovere, @bsunanda, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

[tvami]

type bugfix

[tvami]

@cmsbuild , please test

[tvami]

@cmsbuild, please abort test

• there will be failures in DQM timing reported in RelMon PR comparisons different from before #34445

[tvami]

@cmsbuild, please test with #34464

[cmsbuild]

-1

Failed Tests: AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b90870/16772/summary.html
COMMIT: e3931a0
CMSSW: CMSSW_12_0_X_2021-07-13-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34459/16772/install.sh to create a dev area with all the needed externals and cmssw changes.

AddOn Tests

• hlt_mc_HIon

----- Begin Fatal Exception 13-Jul-2021 18:51:45 CEST-----------------------
An exception of category 'ESGetTokenWrongTransition' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'L1TAnalyzerEndpath'
   [2] Prefetching for module L1TGlobalSummary/'L1TGlobalSummary'
   [3] Prefetching for module L1TGlobalProducer/'simGtStage2Digis'
   [4] Prefetching for module L1TStage2Layer2Producer/'simCaloStage2Digis'
   [5] Prefetching for module L1TCaloLayer1/'simCaloStage2Layer1Digis'
   [6] Prefetching for module EcalTrigPrimProducer/'simEcalTriggerPrimitiveDigis'
   [7] Prefetching for module MixingModule/'mix'
   [8] Calling method for module OscarMTProducer/'g4SimHits'
Exception Message:
The transition ID stored in the ESGetToken does not match the
transition where the token is being used. The associated record
type is: IdealMagneticFieldRecord
For producers, filters and analyzers this transition ID is
set as a template parameter to the call to the esConsumes
function that creates the token. Event is the default transition.
Other possibilities are BeginRun, EndRun, BeginLuminosityBlock,
or EndLuminosityBlock. You may need multiple tokens if you want to
get the same data in multiple transitions. The transition ID has a
different meaning in ESProducers. For ESProducers, the transition
ID identifies the function that produces the EventSetup data (often
there is one function named produce but there can be multiple
functions with different names). For ESProducers, the ESGetToken
must be used in the function associated with the ESConsumesCollector
returned by the setWhatProduced function.
----- End Fatal Exception -------------------------------------------------

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2786302
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2786279
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[tvami]

The addOn test failure doesn't seem to be connected to this PR, hlt_mc_HIon has nothing to do with R-hadron simulation.

[civanch]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b90870/16795/summary.html
COMMIT: e3931a0
CMSSW: CMSSW_12_0_X_2021-07-13-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34459/16795/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2786302
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2786273
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1