"is not" -> "!=" in PatAlgos trigTools.py

[slava77]

to check if a simple solution to #33967 can work

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34253/23536

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @slava77 (Slava Krutelyov) for master.

It involves the following packages:

PhysicsTools/PatAlgos

@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @gouskos, @jdolen, @JyothsnaKomaragiri, @ahinzmann, @schoef, @emilbols, @swozniewski, @jdamgov, @mbluj, @nhanvtran, @gkasieczka, @clelange, @hatakeyamak, @ferencek, @gpetruc, @andrzejnovak, @mariadalfonso, @seemasharmafnal, @mmarionncern this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[slava77]

test parameters:

• addpkg = PhysicsTools/PatExamples,RecoMET/METFilters,TopQuarkAnalysis/Configuration

[slava77]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9b9838/16247/summary.html
COMMIT: 31f276e
CMSSW: CMSSW_12_0_X_2021-06-25-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34253/16247/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• MTD reconstruction: revision of the AODSIM event content #34195 @fabiocos: MTD reconstruction: revision of the AODSIM event content
• Fix in the MPA stub building code #34204 @sviret: Fix in the MPA stub building code
• add unit tests for getPayloadData.py #34199 @mmusich: add unit tests for getPayloadData.py
• Fix for conddb command line tool #34192 @ggovi: Fix for conddb command line tool
• Phase2-hgx287X Next step for V16 Geometry for HGCAL #34201 @bsunanda: Phase2-hgx287X Next step for V16 Geometry for HGCAL

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9b9838/16247/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9b9838/16247/git-merge-result

Comparison Summary

Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 12 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2785711
• DQMHistoTests: Total failures: 357
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2785332
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[slava77]

DQMHistoTests: Total failures: 357

these seem unrelated, but better rerun again after the 2300 IB shows up

[slava77]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9b9838/16250/summary.html
COMMIT: 31f276e
CMSSW: CMSSW_12_0_X_2021-06-25-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34253/16250/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2785711
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2785688
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[slava77]

+reconstruction

for #34253 31f276e

• technical
• jenkins tests pass and comparisons with the baseline show no relevant changes
  • there are differences in several ML inference plots : in 25.0 in what appears to be ONNX-based jet tag, and in 1325.81 one ONNX-based jet tag and one TF-based deep-tau ID. Looking at the job logs, the machines are not the same: orig has SSE4.1 SSE4.2 AVX while the PR has SSE4.1 SSE4.2 AVX AVX2 FMA. Some small differences are expected in this case.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1