[Backport] Modify CaloLayer1 DQM for 5BX needed for Ecal

[hftsoi]

PR description:

Modifications are made to add DQM CaloLayer1 monitoring elements for 5BX, which are needed for ECAL: two 5-bin 1D plots for TPs averages vs BX (with or without Et-weighted), and five 2D TPs occupancy plots. Unpacker is modified to point to the proper sample when filling the 5BX histograms (the middle BX is the "standard").

PR validation:

For testing, the unpacker is modified to fill 5 times the EcalDigisBx for 5BX inside the "if(N_BX==1)" since now we always get BX=1, so the 5BX histograms can get filled for testing (this modification is for our own testing purpose so is not included in this PR). The codes can be compiled and are tested with an offline DQM workflow "runTheMatrix.py -l 10823.0", the 5BX histograms show up in the DQM root files and are properly filled.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport of #33510 to 11_3_X needed for MWGR.

[cmsbuild]

A new Pull Request was created by @hftsoi (Ho-Fung Tsoi) for CMSSW_11_3_X.

It involves the following packages:

DQM/L1TMonitor
EventFilter/L1TRawToDigi

@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @rekovic, @jfernan2, @cecilecaillol, @rvenditti can you please review it and eventually sign? Thanks.
@dinyar, @Martin-Grunewald, @thomreis this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a198c8/15863/summary.html
COMMIT: 89c1e6f
CMSSW: CMSSW_11_3_X_2021-06-09-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34078/15863/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2877742
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2877719
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1456.356 KiB( 37 files compared)
• DQMHistoSizes: changed ( 10024.0,... ): 85.668 KiB L1T/L1TStage2CaloLayer1
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[jfernan2]

@hftsoi Any idea why the added histograms appear empty for all workflows?
https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_11_3_X_2021-06-09-2300+a198c8/43380/dqm-histo-comparison-summary.html

[hftsoi]

@hftsoi Any idea why the added histograms appear empty for all workflows?
https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_11_3_X_2021-06-09-2300+a198c8/43380/dqm-histo-comparison-summary.html

@jfernan2 As I understood this is expected since the firmware is still under test and does not have the correct packing with respect to the unpacker for 5BX (in the unpacker file it's getting N_BX==1 instead of N_BX==5). I've done a local test by filling for new plots in N_BX==1 and the plots are looking fine (please see PR validation).

[jfernan2]

+1

[cecilecaillol]

+l1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1