Modify CaloLayer1 DQM for 5BX needed for Ecal

[hftsoi]

PR description:

Modifications are made to add DQM CaloLayer1 monitoring elements for 5BX, which are needed for ECAL: two 5-bin 1D plots for TPs averages vs BX (with or without Et-weighted), and five 2D TPs occupancy plots. Unpacker is modified to point to the proper sample when filling the 5BX histograms (the middle BX is the "standard").

PR validation:

For testing, the unpacker is modified to fill 5 times the EcalDigisBx for 5BX inside the "if(N_BX==1)" since now we always get BX=1, so the 5BX histograms can get filled for testing (this modification is for our own testing purpose so is not included in this PR). The codes can be compiled and are tested with an offline DQM workflow "runTheMatrix.py -l 10823.0", the 5BX histograms show up in the DQM root files and are properly filled.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Before submitting your pull requests, make sure you followed this checklist:

• verify that the PR is really intended for the chosen branch
• verify that changes follow CMS Naming, Coding, And Style Rules
• verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33510/22254

• This PR adds an extra 32KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33510/22254/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33510/22254/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33510/22255

• This PR adds an extra 36KB to repository

[cmsbuild]

A new Pull Request was created by @hftsoi (Ho-Fung Tsoi) for master.

It involves the following packages:

DQM/L1TMonitor
EventFilter/L1TRawToDigi

@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @rekovic, @jfernan2, @cecilecaillol, @rvenditti can you please review it and eventually sign? Thanks.
@dinyar, @Martin-Grunewald, @thomreis this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[cecilecaillol]

please test

[aloeliger]

@hftsoi,@cecilecaillol Is this change endorsed by @asavincms ?

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-caecce/14535/summary.html
COMMIT: d6979c5
CMSSW: CMSSW_12_0_X_2021-04-22-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33510/14535/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2877046
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2877017
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1456.356 KiB( 37 files compared)
• DQMHistoSizes: changed ( 10024.0,... ): 85.668 KiB L1T/L1TStage2CaloLayer1
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[jfernan2]

Dear @hftsoi
Can you please add yourself along with your github username to corresponding e-group here?
https://twiki.cern.ch/twiki/bin/viewauth/CMS/DQMContacts#ECAL
or
https://twiki.cern.ch/twiki/bin/viewauth/CMS/DQMContacts#L1T
Thanks

[asavincms]

yes, this is ok On Apr 23, 2021, at 12:45 PM, aloeliger ***@***.******@***.***>> wrote: @aloeliger commented on this pull request.

________________________________ In EventFilter/L1TRawToDigi/plugins/implementations_stage2/CaloLayer1Unpacker.cc<#33510 (comment)>:

@@ -32,6 +32,7 @@ namespace l1t {

makeRegions(ctp7_phi, ctp7Data, res->getRegions()); } else if (N_BX == 5) { const uint32_t* ptr5 = ptr; + ptr += 192 * 2; Is this change endorsed by @asavincms<https://github.com/asavincms> ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#33510 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABII5ZG6N6FBIWUSMVW7A53TKFFTNANCNFSM43OFGSJA>.

[cecilecaillol]

+l1

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1