Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run3-gex67 Modify Run3 workflows with changed version of RP devices #33424

Merged
merged 1 commit into from
Apr 16, 2021

Conversation

bsunanda
Copy link
Contributor

PR description:

Modify Run3 workflows with changed version of RP devices (bug fix)

PR validation:

Use scripts from SimG4Core/PrintGeomInfo/test/python to check scenarios defined using DDD and also DD4Hep

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33424/22088

  • This PR adds an extra 32KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

Configuration/Geometry
Geometry/CMSCommonData

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @srimanob, @kpedro88 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @slomeo, @vargasa this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18a46e/14219/summary.html
COMMIT: df99358
CMSSW: CMSSW_11_3_X_2021-04-13-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33424/14219/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 7 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2865526
  • DQMHistoTests: Total failures: 12
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2865491
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 37 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: no differences found

@cvuosalo
Copy link
Contributor

+1

@cvuosalo
Copy link
Contributor

@bsunanda Thanks for cleaning this up.

@srimanob
Copy link
Contributor

+Upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@cvuosalo
Copy link
Contributor

@silviodonato @qliphy If pre6 hasn't been built yet, it would be good to get this PR in pre6.

@srimanob
Copy link
Contributor

@silviodonato @qliphy If pre6 hasn't been built yet, it would be good to get this PR in pre6.

Hi @cvuosalo pre6 built is done,
#33426

@silviodonato
Copy link
Contributor

Yes, we built pre6, but we are waiting for 12_0_X before merging new PRs

@cmsbuild cmsbuild modified the milestones: CMSSW_11_3_X, CMSSW_12_0_X Apr 15, 2021
@qliphy
Copy link
Contributor

qliphy commented Apr 16, 2021

+1

@cmsbuild cmsbuild merged commit df1b846 into cms-sw:master Apr 16, 2021
bsunanda pushed a commit to bsunanda/cmssw that referenced this pull request Apr 17, 2021
cmsbuild added a commit that referenced this pull request Apr 20, 2021
Run3-gex70 Backport 2 PR's #33423 and #33424 to update 2021, 2026 scenarios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants