Validation code update for MTD tracks and hits #33252

gsorrentino18 · 2021-03-23T17:16:07Z

PR description:

This PR expands the validation code for tracks, including monitoring for the following quantities:
-Time and time error of tracks at the different steps of the MTD track reconstruction
-MVA and pathlenght of MTD tracks
-pT resolution wrt General tracks

The validation code for ETL and BTL Reco Hits has also been expanded, adding time and energy resolution MEs and implementing an optional set of histograms for the monitoring of the hits local position, that can be used for dedicated studies.

PR validation:

The new code has been tested in the release CMSSW_11_3_X_2021-03-19-1100

cmsbuild · 2021-03-23T17:30:06Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33252/21720

This PR adds an extra 36KB to repository

cmsbuild · 2021-03-23T17:30:31Z

A new Pull Request was created by @gsorrentino18 (Giulia Sorrentino) for master.

It involves the following packages:

Validation/Configuration
Validation/MtdValidation

@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @mdhildreth, @civanch, @rvenditti can you please review it and eventually sign? Thanks.
@apsallid, @rovere, @fabiocos, @lecriste this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

civanch · 2021-03-23T19:50:54Z

please test

cmsbuild · 2021-03-23T22:18:53Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d4883c/13713/summary.html
COMMIT: f5c759d
CMSSW: CMSSW_11_3_X_2021-03-23-1400/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33252/13713/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 14 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2639783
DQMHistoTests: Total failures: 30
DQMHistoTests: Total nulls: 5
DQMHistoTests: Total successes: 2639726
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 21.304 KiB( 36 files compared)
DQMHistoSizes: changed ( 23234.0,... ): 16.830 KiB MTD/Tracks
DQMHistoSizes: changed ( 23234.0,... ): -13.637 KiB MTD/GlobalReco
DQMHistoSizes: changed ( 23234.0,... ): 2.268 KiB MTD/ETL
DQMHistoSizes: changed ( 23234.0,... ): -0.136 KiB MTD/BTL
DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
Checked 155 log files, 37 edm output root files, 37 DQM output files
TriggerResults: no differences found

civanch · 2021-03-24T07:26:01Z

+1

fabiocos · 2021-03-24T08:21:04Z

Validation/MtdValidation/plugins/BtlLocalRecoValidation.cc

    meHitLongPos_->Fill(recHit.position());
    meHitLongPosErr_->Fill(recHit.positionError());

    meOccupancy_->Fill(global_point.z(), global_point.phi());

+    if (LocalPosDebug_) {
+      meLocalOccupancy_->Fill(local_point.x() + recHit.position(), local_point.y());


@gsorrentino18 is the addition of the reconstructed longitudinal position giving the expected behaviour?

The following occupancy plot (10k MinBias) shows that the BTL crystals are correctly arranged in the module, but there's still something that needs to be understood in the reconstruction of the longitudinal position inside the crystal.

what is observed likely accounts for uncertainty in the reconstructed position that is used on top of the nominal center of the crystal according to the geometry, this is seen also in the one-dimensional plot of the longitudinal position in local coordinates

in any case the 16x3 layout is confirmed to be in the correct orientation, unlike the ETL pixels layout (@parbol FYI)

… axis label

cmsbuild · 2021-03-26T17:15:55Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33252/21784

This PR adds an extra 40KB to repository

cmsbuild · 2021-03-26T17:16:15Z

Pull request #33252 was updated. @andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @mdhildreth, @civanch, @rvenditti can you please check and sign again.

fabiocos · 2021-03-26T17:22:33Z

please test

cmsbuild · 2021-03-26T19:56:35Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d4883c/13800/summary.html
COMMIT: 65147b9
CMSSW: CMSSW_11_3_X_2021-03-26-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33252/13800/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 11 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2639783
DQMHistoTests: Total failures: 16
DQMHistoTests: Total nulls: 5
DQMHistoTests: Total successes: 2639740
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 36.224 KiB( 36 files compared)
DQMHistoSizes: changed ( 23234.0,... ): 17.445 KiB MTD/Tracks
DQMHistoSizes: changed ( 23234.0,... ): -13.637 KiB MTD/GlobalReco
DQMHistoSizes: changed ( 23234.0,... ): 4.014 KiB MTD/ETL
DQMHistoSizes: changed ( 23234.0,... ): 1.232 KiB MTD/BTL
DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
Checked 155 log files, 37 edm output root files, 37 DQM output files
TriggerResults: no differences found

srimanob · 2021-03-28T07:59:57Z

@cms-sw/dqm-l2 @cms-sw/simulation-l2
Do you have comments on this PR? We would like to merge this first, then #33226

jfernan2 · 2021-03-28T15:32:27Z

+1

civanch · 2021-03-28T22:01:28Z

+1

cmsbuild · 2021-03-28T22:01:49Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2021-03-29T00:00:30Z

+1

gsorrentino18 added 4 commits March 22, 2021 15:17

Adding new validation plots for tracks and hits

320065b

Update track validation plugin

fc2a926

Adding MEs for track's time and error

afae069

Update LocalOccupancy plot and removing MEs for non MTD tracks

f5c759d

cmsbuild added this to the CMSSW_11_3_X milestone Mar 23, 2021

cmsbuild added code-checks-pending dqm-pending orp-pending pending-signatures simulation-pending tests-pending labels Mar 23, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 23, 2021

cmsbuild added tests-started and removed tests-pending labels Mar 23, 2021

cmsbuild added tests-approved and removed tests-started labels Mar 23, 2021

cmsbuild added simulation-approved and removed simulation-pending labels Mar 24, 2021

fabiocos reviewed Mar 24, 2021

View reviewed changes

gsorrentino18 added 2 commits March 24, 2021 15:03

Adding monitoring of the BTL rechits longitudinal position and fixing…

0809661

… axis label

minor fix: restoring correct value of LocalPositionDebug flag

1af8dad

cmsbuild removed code-checks-approved simulation-approved tests-approved labels Mar 24, 2021

Update with Fabio's comments and additional MEs

65147b9

cmsbuild added code-checks-pending tests-pending and removed code-checks-approved tests-approved labels Mar 26, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 26, 2021

cmsbuild added tests-started and removed tests-pending labels Mar 26, 2021

cmsbuild added tests-approved and removed tests-started labels Mar 26, 2021

cmsbuild added dqm-approved and removed dqm-pending labels Mar 28, 2021

cmsbuild added fully-signed simulation-approved and removed pending-signatures simulation-pending labels Mar 28, 2021

cmsbuild added orp-approved and removed orp-pending labels Mar 29, 2021

cmsbuild merged commit ea19fe6 into cms-sw:master Mar 29, 2021

fabiocos mentioned this pull request Mar 29, 2021

MTD validation: fix range of pull profiles #33291

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Validation code update for MTD tracks and hits #33252

Validation code update for MTD tracks and hits #33252

gsorrentino18 commented Mar 23, 2021

cmsbuild commented Mar 23, 2021

cmsbuild commented Mar 23, 2021

civanch commented Mar 23, 2021

cmsbuild commented Mar 23, 2021

civanch commented Mar 24, 2021

fabiocos Mar 24, 2021

gsorrentino18 Mar 24, 2021 •

edited

Loading

fabiocos Mar 24, 2021

fabiocos Mar 24, 2021

cmsbuild commented Mar 26, 2021

cmsbuild commented Mar 26, 2021

fabiocos commented Mar 26, 2021

cmsbuild commented Mar 26, 2021

srimanob commented Mar 28, 2021

jfernan2 commented Mar 28, 2021

civanch commented Mar 28, 2021

cmsbuild commented Mar 28, 2021

qliphy commented Mar 29, 2021

Validation code update for MTD tracks and hits #33252

Validation code update for MTD tracks and hits #33252

Conversation

gsorrentino18 commented Mar 23, 2021

PR description:

PR validation:

cmsbuild commented Mar 23, 2021

cmsbuild commented Mar 23, 2021

civanch commented Mar 23, 2021

cmsbuild commented Mar 23, 2021

Comparison Summary

civanch commented Mar 24, 2021

fabiocos Mar 24, 2021

Choose a reason for hiding this comment

gsorrentino18 Mar 24, 2021 • edited Loading

Choose a reason for hiding this comment

fabiocos Mar 24, 2021

Choose a reason for hiding this comment

fabiocos Mar 24, 2021

Choose a reason for hiding this comment

cmsbuild commented Mar 26, 2021

cmsbuild commented Mar 26, 2021

fabiocos commented Mar 26, 2021

cmsbuild commented Mar 26, 2021

Comparison Summary

srimanob commented Mar 28, 2021

jfernan2 commented Mar 28, 2021

civanch commented Mar 28, 2021

cmsbuild commented Mar 28, 2021

qliphy commented Mar 29, 2021

gsorrentino18 Mar 24, 2021 •

edited

Loading