StatOverflows on PixelPhase1 DQM

[arossi83]

PR description:

After the changes introduced in #32364 there is the need to restore the correct behavior for PixelPhase1 DQM plots. With the changes proposed here this is achieve introducing a statsOverflows flag on HistogramManager class.

PR validation:

Tested locally with runTheMatrix, 10824 wf

if this PR is a backport please specify the original PR and why you need to backport that PR:

Not a Backport and not backport needed

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32761/20914

ERROR: Build errors found during clang-tidy run.

DQMServices/Core/src/MonitorElement.cc:907:24: error: out-of-line definition of 'setStatOverflows' does not match any declaration in 'dqm::impl::MonitorElement' [clang-diagnostic-error]
  void MonitorElement::setStatOverflows(bool value) {
                       ^
Suppressed 1377 warnings (1376 in non-user code, 1 with check filters).
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:128: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32761/20917

ERROR: Build errors found during clang-tidy run.

DQMServices/Core/src/MonitorElement.cc:907:24: error: out-of-line definition of 'setStatOverflows' does not match any declaration in 'dqm::impl::MonitorElement' [clang-diagnostic-error]
  void MonitorElement::setStatOverflows(bool value) {
                       ^
Suppressed 1377 warnings (1376 in non-user code, 1 with check filters).
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:128: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32761/20918

• This PR adds an extra 40KB to repository

[cmsbuild]

A new Pull Request was created by @arossi83 (Alessandro Rossi) for master.

It involves the following packages:

DQM/SiPixelPhase1Common
DQMServices/Core

@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks.
@arossi83, @barvic, @hdelanno, @sroychow, @fioriNTU, @jandrea, @idebruyn, @threus this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dfb77f/12579/summary.html
COMMIT: 8b9dbcc
CMSSW: CMSSW_11_3_X_2021-01-27-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/32761/12579/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

• No significant changes to the logs found
• Reco comparison results: 1096 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2716596
• DQMHistoTests: Total failures: 5420
• DQMHistoTests: Total nulls: 19
• DQMHistoTests: Total successes: 2711135
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -45.703 KiB( 36 files compared)
• DQMHistoSizes: changed ( 140.53 ): -44.531 KiB Hcal/DigiRunHarvesting
• DQMHistoSizes: changed ( 140.53 ): -1.172 KiB RPC/DCSInfo
• Checked 156 log files, 37 edm output root files, 37 DQM output files

[jfernan2]

+1
Apart from the differences in wf 140.53 described here:
#32755
changes expected from the inclusion of overflows.
Thanks @arossi83

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1