[DD4hep] Fix DDFilteredView unit test for DD4hep with Geant4 units

[cvuosalo]

With the switch to DD4hep using the Geant4 units convention, a problem in a DDFilteredView unit test was revealed. An earlier change meant that numeric SpecPars with "eval=true" are always evaluated. There was old code in this unit test that assumed unevaluated string values of numerics could be fetched, and this code happened to work as long as the ROOT units convention was in effect. With the units convention change, this code no longer worked and needed a fix.

PR validation:

The code was changed to be invariant under units change, so it should work with the new units convention. But my attempts to test with the cmsdist PR were not successful, so that PR will instead need to be tested against this one.

No backport is needed.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32721/20857

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @cvuosalo (Carl Vuosalo) for master.

It involves the following packages:

DetectorDescription/DDCMS

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@fabiocos, @slomeo, @vargasa this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[cvuosalo]

type bug-fix

[cvuosalo]

@ianna FYI

[cvuosalo]

@mrodozov This PR fixes the first unit test failure in cmsdist PR 6554.

[cvuosalo]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-044d90/12489/summary.html
COMMIT: 2466f9e
CMSSW: CMSSW_11_3_X_2021-01-22-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/32721/12489/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2716961
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2716938
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
• Checked 156 log files, 37 edm output root files, 37 DQM output files

[ianna]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1