Update DD4Hep to latest on master #6554
Conversation
|
A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch IB/CMSSW_11_3_X/master. @cmsbuild, @smuzaffar, @mrodozov can you please review it and eventually sign? Thanks. |
|
please test |
|
-1 Failed Tests: UnitTests RelVals Unit TestsI found errors in the following unit tests: ---> test testDD4hepFilteredView had ERRORS ---> test GeometryDTGeometryBuilderTestDriver had ERRORS ---> test GeometryMTDGeometryBuilderTestDriver had ERRORS ---> test GeometryMTDNumberingBuilderTestDriver had ERRORS ---> test GeometryMTDCommonDataTestDriver had ERRORS RelVals |
|
@mrodozov - yes, thanks! Get attl from hf as double values:
attl 8.09653e-05 == 0.000809653
F
DDFilteredView.cppunit.cc:100:Assertion
Test name: testDDFilteredView::checkFilteredView
assertion failed
- Expression: abs(i - refdattl_[count]) < 10e-6
Failures !!!
Run: 1 Failure total: 1 Failures: 1 Errors: 0
---> test testDD4hepFilteredView had ERRORS
|
|
@mrodozov How is CMSSW being compiled against this version of DD4hep? When CMSSW code includes |
|
@ianna In the line: The value on the left is the calculated value, and on the right it is the reference value. Here, the calculated value is too small. The current code does this: For Geant4 units |
|
please test |
|
@cvuosalo this flag |
|
-1 Failed Tests: UnitTests RelVals Unit TestsI found errors in the following unit tests: ---> test DetectorDescriptionDDCMSTestDriver had ERRORS ---> test testDD4hepCompactView had ERRORS ---> test testDD4hepDDSolid had ERRORS ---> test testDD4hepFilteredViewFind had ERRORS ---> test testDD4hepFilteredView had ERRORS ---> test testDD4hepFilteredViewGet had ERRORS ---> test testDD4hepFilteredViewFirstChild had ERRORS ---> test testDD4hepFilteredViewLevel had ERRORS ---> test testDD4hepFilteredViewGoTo had ERRORS ---> test GeometryDTGeometryBuilderTestDriver had ERRORS ---> test GeometryMuonCommonDataTestDriver had ERRORS and more ... RelVals |
|
@mrodozov , please update https://github.com/cms-sw/cmsdist/blob/IB/CMSSW_11_3_X/master/dd4hep-toolfile.spec and add something like add this line here https://github.com/cms-sw/cmsdist/blob/IB/CMSSW_11_3_X/master/dd4hep-toolfile.spec#L24 |
|
lets fix the toolfile and re-run the tests and see if we unit tests still fail |
having this defined in two places seems a plan for problems. Why can't dd4hep define this internally in a header according to the way make is run? |
|
This is a build time configuration parameter. So either we can patch dd4hep (in our spec) to set it in side one of the dd4hep header (which will avoid the duplication) or we have to use the scram toolfiles |
|
ah right ( https://github.com/cms-sw/cmsdist/pull/6554/files#diff-71d575042aa0c5063c7a3b3456d09216a283b3805936d7ee23702fac27a752e9R27 ), I did not noitce that it is set via cmake ( i thought we were setting it at make time). Yes dd4hep should set it in one of its header |
|
actually the macro to be setup is different from the cmake flag. I made the same mistake :) The C++ macro to be defined is called |
|
@mrodozov , I copuld not find any ref to HAVE_GEANT4_UNITS but I see that DD4HEP_USE_GEANT4_UNITS is the marco used in few dd4hep files e.g. https://github.com/AIDASoft/DD4hep/blob/master/DDParsers/include/Evaluator/DD4hepUnits.h#L128 Currently dd4hep record this marco in the its generated cmake files but as cmssw do not use cmake so that is no use of us. I would suggest that ask dd4hep developers to define this macro in their header file if dd4hep is build with DD4HEP_USE_GEANT4_UNITS ON. this will allow projects without cmake support to use it without re-definiing it in their build system |
|
-1 Failed Tests: UnitTests RelVals Unit TestsI found errors in the following unit tests: ---> test testDD4hepFilteredView had ERRORS ---> test GeometryDTGeometryBuilderTestDriver had ERRORS RelVals |
|
After discussion, we decided that the failing unit tests need a fix. I will work on that. |
|
@mrodozov PR #32721 should fix the |
|
@mrodozov I don't understand the |
|
please test |
|
-1 Failed Tests: UnitTests RelVals Unit TestsI found errors in the following unit tests: ---> test testDD4hepFilteredView had ERRORS ---> test GeometryDTGeometryBuilderTestDriver had ERRORS RelVals
|
|
please test |
|
want to check with IB later than this PR was merged |
|
-1 Failed Tests: UnitTests RelVals Unit TestsI found errors in the following unit tests: ---> test GeometryDTGeometryBuilderTestDriver had ERRORS RelVals
|
|
Pull request #6554 was updated. |
No description provided.