Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Era support for the BMTF Packer #32367

Conversation

panoskatsoulis
Copy link
Contributor

@panoskatsoulis panoskatsoulis commented Dec 2, 2020

backport of #32365 to be used in any 112X MC campaign

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2020

A new Pull Request was created by @panoskatsoulis for CMSSW_11_2_X.

It involves the following packages:

EventFilter/L1TRawToDigi

@cmsbuild, @rekovic, @jmduarte can you please review it and eventually sign? Thanks.
@dinyar, @Martin-Grunewald, @thomreis this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@panoskatsoulis
Copy link
Contributor Author

backport of #32365

@panoskatsoulis
Copy link
Contributor Author

hold

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2020

Pull request #32367 was updated. @cmsbuild, @rekovic, @jmduarte can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2020

Pull request #32367 was updated. @cmsbuild, @rekovic, @jmduarte can you please check and sign again.

@silviodonato
Copy link
Contributor

please test

@silviodonato silviodonato marked this pull request as draft December 10, 2020 08:39
@silviodonato
Copy link
Contributor

@panoskatsoulis please push on "Ready for review", when the PR is ready

@cms-sw cms-sw deleted a comment from cmsbuild Dec 10, 2020
@cms-sw cms-sw deleted a comment from cmsbuild Dec 10, 2020
@cms-sw cms-sw deleted a comment from cmsbuild Dec 10, 2020
@cms-sw cms-sw deleted a comment from cmsbuild Dec 10, 2020
@smuzaffar
Copy link
Contributor

please test

@smuzaffar
Copy link
Contributor

smuzaffar commented Dec 10, 2020

abort
This branch panoskatsoulis:bmtf_eraconfig_packer_unpacker is used to create PRs for cmssw master and CMSSW_11_2_X. Bot is testing the same commit for both PRs (#32365 and #32367) , the confuses bot. I would suggest to only test it at one place or create two branches

@panoskatsoulis
Copy link
Contributor Author

@smuzaffar
we were testing it in the PR for the master only but after changes in the discrepancies that were seen in the tests, I was thinking of that these discrepancies might exist because of the baseline used in the tests.
For this reason, I asked to test in the backport.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants